[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(page-functions): don't try to clone a ShadowRoot #9079

Merged
merged 9 commits into from
Jun 7, 2019
Merged

core(page-functions): don't try to clone a ShadowRoot #9079

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a5f9343
#9048 Fix Avoid an excess DOM size error
NickolasBenakis May 29, 2019
5de9be9
bug-fix: Avoid an excess DOM size error #9079
NickolasBenakis May 29, 2019
bf80f17
bug-fix: Avoid an excess DOM size error #9079
NickolasBenakis May 29, 2019
f34fd58
updates
patrickhulce May 31, 2019
51449a0
fix tests I broke
patrickhulce May 31, 2019
a1528b6
Add test for nodes that cannot be inspected
NickolasBenakis Jun 1, 2019
13d4753
Update lighthouse-core/lib/page-functions.js
NickolasBenakis Jun 4, 2019
29b209d
Update lighthouse-core/test/lib/page-functions-test.js
NickolasBenakis Jun 4, 2019
cbd0e48
ShadowRoot
brendankenny Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests I broke
  • Loading branch information
@patrickhulce
patrickhulce committed May 31, 2019
commit 51449a067843fea6fd43b421c14a9b6f44d36a15
2 changes: 1 addition & 1 deletion lighthouse-core/lib/page-functions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// @ts-nocheck
'use strict';

/* global window document Node */
/* global window document Node ShadowRoot */

/**
* Helper functions that are passed by `toString()` by Driver to be evaluated in target page.
Expand Down
7 changes: 6 additions & 1 deletion lighthouse-core/test/lib/page-functions-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,15 @@ describe('Page Functions', () => {
let dom;

beforeAll(() => {
const {document} = new jsdom.JSDOM().window;
const {document, ShadowRoot} = new jsdom.JSDOM().window;
global.ShadowRoot = ShadowRoot;
dom = new DOM(document);
});

afterAll(() => {
global.ShadowRoot = undefined;
});

describe('get outer HTML snippets', () => {
it('gets full HTML snippet', () => {
assert.equal(pageFunctions.getOuterHTMLSnippet(
Expand Down