[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: localize audits in best-practices #9092

Merged
merged 14 commits into from
Jun 25, 2019
Merged

i18n: localize audits in best-practices #9092

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f328fec
Initial best practices i18n collection.
exterkamp May 31, 2019
cb84821
linting
exterkamp May 31, 2019
f2c45c0
Fix tests, fix off-by-one error in is-on-https
exterkamp May 31, 2019
69d3c39
Update table headers.
exterkamp May 31, 2019
54704d1
fixed test
exterkamp May 31, 2019
197dc4b
Initial descriptions.
exterkamp May 31, 2019
9706bc9
Merge branch 'master' into best_prac_i18n
exterkamp Jun 10, 2019
93a81cb
Stringback Batch suggestions
exterkamp Jun 12, 2019
e50a72e
replace 'site' with 'page' in description strings
exterkamp Jun 12, 2019
ed99afe
a page -> the page
exterkamp Jun 12, 2019
cc06d9d
Converted column description strings to new format
exterkamp Jun 12, 2019
c95602f
Merge branch 'master' into best_prac_i18n
exterkamp Jun 18, 2019
fa189b6
brendan foodback round 2
exterkamp Jun 25, 2019
e04fa20
fixed tests
exterkamp Jun 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed test
  • Loading branch information
@exterkamp
exterkamp committed May 31, 2019
commit 54704d17c0cc79b5c0b03584cf2f2d96fcfbaece
4 changes: 2 additions & 2 deletions lighthouse-core/test/audits/dobetterweb/uses-http2-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ describe('Resources are fetched over http/2', () => {
'https://webtide.com/wp-content/plugins/wp-pagenavi/pagenavi-css.css?ver=2.70'
);
const headers = auditResult.details.headings;
assert.equal(headers[0].text, 'URL', 'table headings are correct and in order');
assert.equal(headers[1].text, 'Protocol', 'table headings are correct and in order');
expect(headers[0].text).toBeDisplayString('URL');
expect(headers[1].text).toBeDisplayString('Protocol');
}
);
});
Expand Down