[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(tracehouse): allow missing FCP #9174

Merged
merged 6 commits into from
Jun 20, 2019
Merged

core(tracehouse): allow missing FCP #9174

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b4bdbb0
core(tracehouse): allow missing FCP
patrickhulce Jun 10, 2019
f1b007c
lint
patrickhulce Jun 10, 2019
f631271
add counter test
patrickhulce Jun 10, 2019
01e1ceb
manually construct traceOfTab
patrickhulce Jun 19, 2019
d7395ae
remove no fcp test
patrickhulce Jun 19, 2019
fc6c18c
last feedback
patrickhulce Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@patrickhulce
patrickhulce committed Jun 10, 2019
commit f1b007ccc4837072e07d6149583a8af641ec5287
2 changes: 1 addition & 1 deletion lighthouse-core/lib/tracehouse/trace-processor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ class TraceProcessor {
const firstPaint = frameEvents.find(e => e.name === 'firstPaint' && e.ts > navigationStart.ts);

// FCP will follow at/after the FP. Used in so many places we require it.
let firstContentfulPaint = frameEvents.find(
const firstContentfulPaint = frameEvents.find(
e => e.name === 'firstContentfulPaint' && e.ts > navigationStart.ts
);
if (!firstContentfulPaint && throwOnNoFCP) throw this.createNoFirstContentfulPaintError();
Expand Down