[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: rename exports to tools #9135

Merged
merged 6 commits into from
Jun 8, 2019
Merged

report: rename exports to tools #9135

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
34106be
misc: rename exports to tools
connorjclark Jun 6, 2019
ce6acda
Update lighthouse-core/report/html/templates.html
connorjclark Jun 6, 2019
a7899ab
Merge remote-tracking branch 'origin/master' into exports-to-tool
connorjclark Jun 7, 2019
4806659
onToolAction
connorjclark Jun 7, 2019
7c422f8
comment
connorjclark Jun 7, 2019
b46ba3a
fix merge
connorjclark Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
onToolAction
  • Loading branch information
@connorjclark
connorjclark committed Jun 7, 2019
commit 4806659a92da0e4ad42820e495e0edb4b93ef4ad
6 changes: 3 additions & 3 deletions lighthouse-core/report/html/renderer/report-ui-features.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class ReportUIFeatures {
this.>
this.>
this.>
this.onExport = this.onExport.bind(this);
this.onToolAction = this.onToolAction.bind(this);
this.>
this.>
this.>
Expand Down Expand Up @@ -210,7 +210,7 @@ class ReportUIFeatures {
this.toolsButton.addEventListener('click', this.onToolsButtonClick);

const dropdown = this._dom.find('.lh-tools__dropdown', this._document);
dropdown.addEventListener('click', this.onExport);
dropdown.addEventListener('click', this.onToolAction);
}

_setupThirdPartyFilter() {
Expand Down Expand Up @@ -405,7 +405,7 @@ class ReportUIFeatures {
* Handler for tool button.
* @param {Event} e
*/
onExport(e) {
onToolAction(e) {
e.preventDefault();

const el = /** @type {?Element} */ (e.target);
Expand Down