[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: fix typo in performance-budget smoke test #9244

Merged
merged 2 commits into from
Jun 26, 2019
Merged

misc: fix typo in performance-budget smoke test #9244

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c33ee60
misc: ArrayBuffer.byteLength instead of .length in perf budge smoke test
connorjclark Jun 21, 2019
e99cfcb
simplify changes
connorjclark Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lighthouse-cli/test/fixtures/perf/perf-budgets/load-things.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
// Load file as 'other' resource.
const response = await fetch('http://localhost:10503/preload.html');
const ab = await response.arrayBuffer();
document.querySelector('#corsfont').textContent = ab.length;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is just about text and doesn't matter at all right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk, would the font be loaded if there were no text?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, oh I see what I'm missing now sorry :)

  1. new ArrayBuffer().length === undefined, not just a semantic difference like in node
  2. el.textContent = undefined clears all textContent, and does not do some sort of string coercion to "undefined"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

el.textContent = undefined clears all textContent, and does not do some sort of string coercion to "undefined"

just to be clear, while the actual behavior is unintended and pointless, the intended behavior was also pointless. There's no reason to add this to the page at all, just making sure (poorly, it turns out) the thing is actually loaded and used :)

document.querySelector('.corsfont').textContent = ab.byteLength;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, good catch. Clearly QA was lying down on the job for this page :)

}
yah();
</script>
Expand All @@ -40,7 +40,7 @@
<img style="width: 100px; height: 100px;" src="../../byte-efficiency/large.svg">
<p class="webfont">Ripping off some webfont smoke tests</p>
<p><strong class="webfont">Do we need such text</strong></p>
<p id="corsfont"></p>
<p class="corsfont"></p>
<script src="../level-2.js"></script>
</body>
</html>
20 changes: 10 additions & 10 deletions lighthouse-cli/test/smokehouse/perf/expectations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,11 @@ module.exports = [
audits: {
'resource-summary': {
score: null,
displayValue: '11 requests • 164 KB',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for anyone else scratching their head how in the world this was affected by the fixture change when .corsfont doesn't appear anywhere else in load-things.html, the CSS rule is defined over in cors-fonts.css :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my fault, it was sloppy to change it only a little and then draw a line in the sand for the budgets at that point :)

No memory of why I didn't change the classname itself from what's in fonts.html, just operating as a human fuzzer at the time, I think :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I'm still not clear why we need to use it at all no harm no foul I was just baffled how his text change could result in fonts getting requested 😆

I think I was just slow on the uptake that this was modeled after another file

displayValue: '12 requests • 211 KB',
details: {
items: [
{resourceType: 'total', requestCount: 11, size: '168000±1000'},
{resourceType: 'font', requestCount: 2, size: '80000±1000'},
{resourceType: 'total', requestCount: 12, size: '215000±1000'},
{resourceType: 'font', requestCount: 3, size: '128000±1000'},
{resourceType: 'script', requestCount: 3, size: '55000±1000'},
{resourceType: 'image', requestCount: 2, size: '28000±1000'},
{resourceType: 'document', requestCount: 1, size: '2100±100'},
Expand All @@ -94,19 +94,19 @@ module.exports = [
items: [
{
resourceType: 'total',
countOverBudget: '3 requests',
sizeOverBudget: '65000±1000',
countOverBudget: '4 requests',
sizeOverBudget: '113000±1000',
},
{
resourceType: 'font',
countOverBudget: '1 request',
sizeOverBudget: '52000±1000',
},
{
resourceType: 'script',
countOverBudget: '2 requests',
sizeOverBudget: '25000±1000',
},
{
resourceType: 'font',
countOverBudget: undefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the intention was to make sure we got a good mixture of the combinations of defined and undefined for these entries, so ideally this wouldn't change from undefined.

Maybe the "Undefined items" comment above could be changed to be a little more strongly worded to warn about that and we could change corsfont to something completely different so it doesn't look like a bug that it's not getting the font?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change corsfont to something completely different so it doesn't look like a bug that it's not getting the font?

yea, sounds good i'll do that and revert all these expectation changes

sizeOverBudget: '4000±500',
},
{
resourceType: 'document',
countOverBudget: '1 request',
Expand Down