[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(runner): add assertion for devtoolsLog as requiredArtifact #9290

Merged
merged 2 commits into from
Jun 27, 2019
Merged

misc(runner): add assertion for devtoolsLog as requiredArtifact #9290

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f235a32
core(runner): add assertion for devtoolsLog as requiredArtifact
brendankenny Jun 27, 2019
6f58f43
-TODO
brendankenny Jun 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
-TODO
  • Loading branch information
@brendankenny
brendankenny committed Jun 27, 2019
commit 6f58f43443096231312b023e5b54d6796c79f7d9
2 changes: 1 addition & 1 deletion lighthouse-core/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ class Runner {
const noArtifact = artifacts[artifactName] === undefined;

// If trace/devtoolsLog required, check that DEFAULT_PASS trace/devtoolsLog exists.
// TODO: need pass-specific check of traces and devtoolsLogs.
// NOTE: for now, not a pass-specific check of traces or devtoolsLogs.
const noRequiredTrace = artifactName === 'traces' && !artifacts.traces[Audit.DEFAULT_PASS];
const noRequiredDevtoolsLog = artifactName === 'devtoolsLogs' &&
!artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
Expand Down