[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: support saving and loading error artifacts #9397

Merged
merged 6 commits into from
Jul 20, 2019
Merged

core: support saving and loading error artifacts #9397

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be5c3cb
core: support saving and loading error artifacts
brendankenny Jul 17, 2019
e1968bd
revert some stuff
brendankenny Jul 17, 2019
977f8a1
tighter types
brendankenny Jul 17, 2019
3ce20d2
appveyor debugging
brendankenny Jul 17, 2019
12e460f
windows path separators
brendankenny Jul 17, 2019
73c79c2
feedback
brendankenny Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tighter types
  • Loading branch information
@brendankenny
brendankenny committed Jul 17, 2019
commit 977f8a137b8b606b293afbda4e005ed7b1ee99c2
4 changes: 2 additions & 2 deletions lighthouse-core/lib/lh-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ class LighthouseError extends Error {
* A JSON.stringify replacer to serialize LHErrors and (as a fallback) Errors.
* Returns a simplified version of the error object that can be reconstituted
* as a copy of the original error at parse time.
* @param {unknown} err
* @return {SerializedBaseError | SerializedLighthouseError}
* @param {Error|LighthouseError} err
* @return {SerializedBaseError|SerializedLighthouseError}
*/
static stringifyReplacer(err) {
if (err instanceof LighthouseError) {
Expand Down