[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clients(lightrider): serialize errors in artifacts #9410

Merged
merged 13 commits into from
Jul 24, 2019
Merged

clients(lightrider): serialize errors in artifacts #9410

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
be5c3cb
core: support saving and loading error artifacts
brendankenny Jul 17, 2019
e1968bd
revert some stuff
brendankenny Jul 17, 2019
977f8a1
tighter types
brendankenny Jul 17, 2019
3ce20d2
appveyor debugging
brendankenny Jul 17, 2019
12e460f
windows path separators
brendankenny Jul 17, 2019
73c79c2
feedback
brendankenny Jul 18, 2019
0cf7402
clients(lightrider): serialize errors in artifacts
connorjclark Jul 18, 2019
e932e33
update
connorjclark Jul 18, 2019
181cc8e
Merge remote-tracking branch 'origin/master' into lr-error-serialize
connorjclark Jul 20, 2019
e23131c
update
connorjclark Jul 20, 2019
c7aebaa
comment
connorjclark Jul 23, 2019
0836365
tst
connorjclark Jul 23, 2019
6e03048
fx
connorjclark Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tst
  • Loading branch information
@connorjclark
connorjclark committed Jul 23, 2019
commit 0836365498e37b3e81355a4ceb1798dbc99a8674
27 changes: 27 additions & 0 deletions clients/test/lightrider-entry-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,5 +118,32 @@ describe('lightrider-entry', () => {

runStub.mockRestore();
});

it('exposes artifacts when logAssets is true', async () => {
const originalRun = Runner.run;
Runner.run = jest.fn().mockReturnValue(Promise.resolve({
lhr: {},
artifacts: {
Artifact: new Error('some error'),
},
}));
afterEach(() => {
Runner.run = originalRun;
});

const mockConnection = {};
const url = 'https://example.com';
const lrFlags = {
logAssets: true,
};
const resultJson = await lhBackground.runLighthouseInLR(mockConnection, url, {}, lrFlags);
const result = JSON.parse(resultJson);
expect(result.artifacts).toMatchObject({
Artifact: {
sentinel: '__ErrorSentinel',
message: 'some error',
},
});
});
});
});