-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: add largest contentful paint to lantern and default config #9905
Merged
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
ec75de3
first pass
connorjclark 183b080
update
connorjclark 03f8ab6
i18n
connorjclark 52a8d28
typos
connorjclark 4e2e688
metrics
connorjclark f1836a0
ts
connorjclark 449c7c5
fix
connorjclark d821da7
Apply suggestions from code review
connorjclark 9cc6b8c
todo
connorjclark 211a90b
fix lcp
connorjclark ee9f34e
update sample trace
connorjclark 24db2ed
tweaks
connorjclark 308f0fe
fix metrics-test
connorjclark 33fecc9
rename all those pwa trace requires
connorjclark 2b87da0
just update all the metric snapshots
connorjclark c473bf5
undo tests
connorjclark 26bb02a
m79 in metrics test
connorjclark b848a73
m60
connorjclark 967d630
lcp metric trace test
connorjclark 5b80688
Merge remote-tracking branch 'origin/master' into lcp
connorjclark 9da66f9
pr
connorjclark 49aa30a
Update lighthouse-core/lib/tracehouse/trace-processor.js
connorjclark a71ab04
Merge branch 'lcp' of github.com:GoogleChrome/lighthouse into lcp
connorjclark 7fd52f4
Apply suggestions from code review
connorjclark f351590
update traces
connorjclark ff42528
minify trace
connorjclark e93e396
first pass
connorjclark 9103431
wip
connorjclark a3fade6
fix print
connorjclark 567efc2
improve
connorjclark 459a1de
Merge remote-tracking branch 'origin/master' into lcp-lantern
connorjclark a0b31db
lint, update with master
connorjclark 045b829
add lcp to default config
connorjclark 498df14
fix tests
connorjclark 7bb9d86
rm stuff
connorjclark de48435
Merge remote-tracking branch 'origin/master' into lcp-lantern
connorjclark eb3599e
pr
connorjclark 6d12f11
Apply suggestions from code review
connorjclark fa7f089
lint. line length
paulirish 42b7ad1
fix lantern test
connorjclark 8b5cce0
Merge remote-tracking branch 'origin/master' into lcp-lantern
connorjclark ce0042b
fix tests
connorjclark bbc5030
fix trace processor test
connorjclark 9812701
rm common prefix
connorjclark e0a04b7
fix cli test
connorjclark 2d34e65
delete old test
connorjclark 6a1fdb7
pr
connorjclark 1579ccb
comment
connorjclark 5fc5db0
Merge remote-tracking branch 'origin/master' into lcp-lantern
connorjclark 98f3ea2
use a better trace for lcp
connorjclark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lcp metric trace test
- Loading branch information
commit 967d63031cbc667885004be3efb6023cf5adaf66
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FCP, FMP, SI, and TTI flipped to undefined. i don't think that's expected is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we went from devtools to simulate so i think these are expected to be undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oic.