Adding UDF Testing Framework #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ynamic dataset which is set using the default_dataset parameter when executing queries.
Restructuring to only use one test class with parameterized parallel test methods
# Conflicts: # udfs/community/README.md # udfs/migration/redshift/README.md
…ery-utils � Conflicts: � udfs/community/README.md
jaketf
suggested changes
Feb 12, 2020
jaketf
reviewed
Apr 4, 2020
jaketf
suggested changes
Apr 4, 2020
There was a problem hiding this comment.
Finally getting back to this thanks for your patience.
Let's use pathlib then this is LGTM.
In a subsequent PR I'd love to tease out the general parts from the parts specific to this repo so we could release this framework on PyPi w/ extra docs on using outside the context of this repo.
For example, I'd like to be able to pip install this for use in ci-cd-for-data-processing-workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of previous PR: #21