[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compute): compute_ip_address_unassign_static_address sample #4196

Merged
merged 3 commits into from
Jun 30, 2024
Merged

feat(compute): compute_ip_address_unassign_static_address sample #4196

merged 3 commits into from
Jun 30, 2024
+123 −1

Conversation

irudykss
Copy link
Collaborator

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples. labels Jun 18, 2024
@irudykss irudykss requested a review from muncus June 18, 2024 08:13
@irudykss irudykss marked this pull request as ready for review June 18, 2024 08:13
@irudykss irudykss requested review from a team as code owners June 18, 2024 08:13
@irudykss irudykss added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 18, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 18, 2024
@irudykss irudykss added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 19, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 19, 2024
muncus
muncus previously requested changes Jun 24, 2024
View reviewed changes
compute/address/address_test.go Outdated Show resolved Hide resolved
@BigBlackWolf BigBlackWolf requested a review from a team as a code owner June 26, 2024 09:41
@BigBlackWolf BigBlackWolf added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 26, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 26, 2024
@BigBlackWolf BigBlackWolf requested a review from muncus June 26, 2024 13:49
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2024
@BigBlackWolf BigBlackWolf dismissed muncus’s stale review June 30, 2024 13:50

Changes added in separate commit

@BigBlackWolf BigBlackWolf merged commit 6471216 into main Jun 30, 2024
11 checks passed
@BigBlackWolf BigBlackWolf deleted the samples/compute_ip_address_unassign_static_address branch June 30, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-strzelczyk m-strzelczyk m-strzelczyk approved these changes

@muncus muncus Awaiting requested review from muncus

Assignees

@muncus muncus

Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@irudykss @muncus @m-strzelczyk @BigBlackWolf @kokoro-team