[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: GitHub raw URL references to notebook. #818

Merged
merged 3 commits into from
Jun 28, 2024
Merged

fix: GitHub raw URL references to notebook. #818

merged 3 commits into from
Jun 28, 2024

Conversation

ianlewis
Copy link
Contributor
@ianlewis ianlewis commented Jun 28, 2024 •
edited
Loading

Description

GitHub does not seem to honor raw URLs with a blob/ path component any more. These URLs result in a 404 response.

  • Follow the CONTRIBUTING Guide.
  • You are listed as the author in your notebook or README file.
    • Your account is listed in CODEOWNERS for the file(s).
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
  • Ensure the tests and linter pass (Run nox -s format from the repository root to format).
  • Appropriate docs were updated (if necessary)

Fixes #817 馃

@ianlewis ianlewis requested a review from a team as a code owner June 28, 2024 06:31
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on聽 ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ianlewis ianlewis changed the title Fix GitHub raw URL refernces to notebook. Fix GitHub raw URL references to notebook. Jun 28, 2024
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link
conventional-commit-lint-gcf bot commented Jun 28, 2024 •
edited
Loading

馃 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@ianlewis ianlewis changed the title Fix GitHub raw URL references to notebook. fix: GitHub raw URL references to notebook. Jun 28, 2024
@ianlewis
fix: GitHub raw URL references to notebook.
2ecc26c 
GitHub does not seem to honor raw URLs with a `blob/` path component any
more. These URLs result in a 404 response.

Fixes GoogleCloudPlatform#817

Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis ianlewis force-pushed the 817-bug-github-raw-urls-result-in-404 branch from 192e46e to 2ecc26c Compare June 28, 2024 07:00
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2024
@github-actions GitHub Actions
Copy link

@check-spelling-bot Report

馃敶 Please review

See the 馃搨 files view, the 馃摐action log, or 馃摑 job summary for details.

Unrecognized words (1)

occured

Warnings (1)

See the 馃搨 files view, the 馃摐action log, or 馃摑 job summary for details.

鈿狅笍 Warnings Count
鈿狅笍 ignored-expect-variant 1

See 鈿狅笍 Event descriptions for more information.

@ianlewis
Copy link
Contributor Author
  • Spelling errors were in the original notebook. Out of scope for the PR
  • "Lint Code Base" check is a false positive error matching Facebook page access token to a base64 representation of an image.

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2024
holtskinner
holtskinner approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator
@holtskinner holtskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2024
@holtskinner holtskinner merged commit dc4f38f into GoogleCloudPlatform:main Jun 28, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holtskinner holtskinner holtskinner approved these changes

@lavinigam-gcp lavinigam-gcp Awaiting requested review from lavinigam-gcp lavinigam-gcp is a code owner automatically assigned from GoogleCloudPlatform/generative-ai-devrel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: GitHub raw URLs result in 404
2 participants
@ianlewis @holtskinner