[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CODEOWNERS): Add cloud-samples-reviewers as a global sample owner #3720

Merged
merged 3 commits into from
Jun 22, 2024

Conversation

grayside
Copy link
Collaborator

Description

This change adds the new GoogleCloudPlatform/cloud-samples-reviewers for all samples reviews, makes them a default owner on the repo to cover gaps, and then excludes it from ownership on repository infrastructure & common configuration files.

This is the first PR to add this team to a repo, and is being used to confirm the approach.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 20, 2024
@grayside grayside changed the title Update CODEOWNERS: Add cloud-samples-reviewers chore(CODEOWNERS): Add cloud-samples-reviewers as a general sample owner Jun 20, 2024
Copy link
conventional-commit-lint-gcf bot commented Jun 20, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@grayside grayside changed the title chore(CODEOWNERS): Add cloud-samples-reviewers as a general sample owner chore(CODEOWNERS): Add cloud-samples-reviewers as a global sample owner Jun 20, 2024
CODEOWNERS Outdated Show resolved Hide resolved
@grayside grayside self-assigned this Jun 20, 2024
@grayside grayside marked this pull request as ready for review June 20, 2024 21:40
@grayside grayside requested a review from a team as a code owner June 20, 2024 21:40
@grayside grayside enabled auto-merge (squash) June 20, 2024 21:41
@iennae iennae added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2024
@grayside grayside merged commit 7744b29 into main Jun 22, 2024
30 checks passed
@grayside grayside deleted the codeowners/cloud-samples-reviewers branch June 22, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants