[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: finish upgrading firestore samples #1381

Merged
merged 3 commits into from
Jun 18, 2021
Merged

chore: finish upgrading firestore samples #1381

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2339a49
finish upgrading firestore samples
bshaffer Jun 11, 2021
70cc914
Merge branch 'master' into upgrade-firestore-samples
bshaffer Jun 16, 2021
0c63d35
fix tests
bshaffer Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix tests
  • Loading branch information
@bshaffer
bshaffer committed Jun 17, 2021
commit 0c63d35b4aa2614c35b2f2854c7decdc7c2960ff
1 change: 0 additions & 1 deletion firestore/src/data_delete_collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
namespace Google\Cloud\Samples\Firestore;

use Google\Cloud\Firestore\FirestoreClient;
use Google\Cloud\Firestore\CollectionReference;

/**
* Delete a collection.
Expand Down
6 changes: 3 additions & 3 deletions firestore/test/firestoreTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,8 +361,8 @@ public function testDeleteCollection()
$col = self::$firestoreClient->collection('samples/php/cities');
$output = $this->runFirestoreSnippet('data_delete_collection', [
self::$projectId,
'collectionReference' => $col->name(),
'batchSize' => 2,
$col->name(),
2,
]);

$this->assertStringContainsString('Deleting document BJ', $output);
Expand Down Expand Up @@ -691,7 +691,7 @@ private static function runFirestoreSnippet($snippetName, array $args = null)
{
if ($args === null) {
$args = [
'projectId' => self::$firestoreProjectId
self::$firestoreProjectId
];
}

Expand Down