[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix, chore, refactor(egen): REST api fixes, KFP v2 refactor, new template #3180

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

krishr2d2
Copy link
Contributor

This PR includes the following updates to the `pipeline_intro_kfp.ipynb` notebook:
  • Refactors code to use KFP v2.
  • Fixes the REST API request payload for pipeline job creation.
  • Updates the cleaning up section: include local files, remove pipeline jobs (not needed).
  • Adds Colab authentication and kernal restart steps.
  • Adds colab enterprise logo with link.
  • Makes Heading changes according to template guidelines.
  • Remove duplicate sentences / explanation.
  • Fix unnecessary "``" code highlight usage.
  • Replace REGION with LOCATION.
  • Removes IS_TESTING condition.



REQUIRED: Fill out the below checklists or remove if irrelevant

  1. If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:
  • Use the notebook template as a starting point.
  • Follow the style and grammar rules outlined in the above notebook template.
  • Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
  • You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
  • The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

…ctors to use the latest SDKs, follows the new template, sentence corrections
@krishr2d2 krishr2d2 requested a review from a team as a code owner July 1, 2024 11:11
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator
@kittyabs kittyabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

several needed edits

notebooks/official/pipelines/pipelines_intro_kfp.ipynb Outdated Show resolved Hide resolved
notebooks/official/pipelines/pipelines_intro_kfp.ipynb Outdated Show resolved Hide resolved
notebooks/official/pipelines/pipelines_intro_kfp.ipynb Outdated Show resolved Hide resolved
notebooks/official/pipelines/pipelines_intro_kfp.ipynb Outdated Show resolved Hide resolved
notebooks/official/pipelines/pipelines_intro_kfp.ipynb Outdated Show resolved Hide resolved
@katiemn
Copy link
Collaborator
katiemn commented Jul 1, 2024

/gcbrun

@katiemn katiemn added this pull request to the merge queue Jul 1, 2024
Merged via the queue into GoogleCloudPlatform:main with commit bb3d3bd Jul 1, 2024
6 checks passed
@krishr2d2 krishr2d2 deleted the pipelines_intro_kfp branch July 2, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants