[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add np.float128,np.complex256 dtypes to vspaces and boxes registers #590

Closed
mduschenes opened this issue Apr 5, 2023 · 2 comments
Closed

Add np.float128,np.complex256 dtypes to vspaces and boxes registers #590

mduschenes opened this issue Apr 5, 2023 · 2 comments

Comments

@mduschenes
Copy link
Contributor

Please add np.float128 and np.complex256 dtypes to the numpy ArrayBox and ArrayVSpace register of mappings (Gradients appear to be computed correctly once dtypes are added to lists) Thank you.

autograd/autograd/numpy/numpy_boxes.py

Lines 51 to 53 in 81b288e

for type_ in [float, np.float64, np.float32, np.float16,
complex, np.complex64, np.complex128]:
ArrayBox.register(type_)

autograd/autograd/numpy/numpy_vspaces.py

Lines 61 to 65 in 81b288e

for type_ in [float, np.float64, np.float32, np.float16]:
ArrayVSpace.register(type_)
for type_ in [complex, np.complex64, np.complex128]:
ComplexArrayVSpace.register(type_)

@j-towns
Copy link
Collaborator
j-towns commented Apr 15, 2023

If you can submit a pull request with these changes I'd be happy to merge it.

@mduschenes mduschenes mentioned this issue Apr 18, 2023
Merged
@mduschenes
Copy link
Contributor Author

Thanks!

j-towns added a commit that referenced this issue Apr 20, 2023
@j-towns
Merge pull request #591 from mduschenes/float128-complex256-vspaces-b…
23fcdb0 
…oxes-issue-590

added float128, complex256 dtypes to numpy vspaces and boxes for #590
@j-towns j-towns closed this as completed Apr 20, 2023
@agriyakhetarpal agriyakhetarpal mentioned this issue Jun 22, 2023
Closed
j-towns added a commit that referenced this issue Jun 22, 2023
@j-towns
Revert "added float128, complex256 dtypes to numpy vspaces and boxes …
bc1a0fb 
…for #590"

This reverts commit efecc64.

See #601.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@j-towns @mduschenes