[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update coconutbattery to 3.7 #52761

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Update coconutbattery to 3.7 #52761

merged 1 commit into from
Oct 3, 2018

Conversation

tiiiecherle
Copy link
Contributor

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} left no offenses.
  • The commit message includes the cask’s name and version.

vitorgalvao
vitorgalvao suggested changes Oct 3, 2018
View reviewed changes
Copy link
Member
@vitorgalvao vitorgalvao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since sha256 was updated but version stayed the same, this change needs to be verified. Please follow the instructions to do so.

@tiiiecherle
Copy link
Contributor Author

Just downloaded from the dev website

shasum --algorithm 256 /Users/tom/Desktop/files/coconutBattery_3.7.zip
0993860896d498ffc4bf9c6b6f25d724bfa0a967b19fb211eb347547118f3a2e  /Users/tom/Desktop/files/coconutBattery_3.7.zip

I don`t know why the checksum changed.

@tiiiecherle
Copy link
Contributor Author

The VirusTotal Site really shows included adware. Is it intentional by the developer?

https://www.virustotal.com/#/file/0993860896d498ffc4bf9c6b6f25d724bfa0a967b19fb211eb347547118f3a2e/detection

@tiiiecherle
Copy link
Contributor Author

I don`t know if this was already included in the old release...

@vitorgalvao
Copy link
Member

The release is signed, so it seems to be legit. Mind contacting them about the malware?

@tiiiecherle
Copy link
Contributor Author
tiiiecherle commented Oct 3, 2018 •
edited
Loading

The release is signed, so it seems to be legit. Mind contacting them about the malware?

done ;) wrote them an email.

@tiiiecherle
Copy link
Contributor Author

I got a response from the developer and asked him to post the content of the email here, so that everybody knows.

Hey

Thanks for your mail!
Indeed the checksum has changed because I did some minor changes to the package and had to reupload it.
I never knew that the app can be installed by homebrew, so it’s good to know that I have to be careful with package reuploads as this breaks the checksum check.

As I only swapped out an internal data structure this is a false positive by Qihoo-360.
You can confirm this by scanning the actual binary files.
https://www.virustotal.com/#/file/ae262332bf144e187b8e5cdd025c2c5cd550c7bcce8c523b4db3284b446c4fd2/detection

I have to check why only the zip file seems to cause this false detection while the actual binaries are ok.
Until then there’s nothing I can do at the moment.

Best
Chris

@vitorgalvao
Copy link
Member

Thank you. Since it’s signed, it can be merged.

@vitorgalvao vitorgalvao merged commit b7d291c into Homebrew:master Oct 3, 2018
@lock lock bot locked and limited conversation to collaborators Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitorgalvao vitorgalvao vitorgalvao requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tiiiecherle @vitorgalvao