This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
Including postprocess in 3D section of protocol.conf #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @dmaluenda, to be honest, each plugin can decide where to put each of its protocols. Adding this line here will not warranty anything. It will serve as a "hint". |
|
mmm, I'm not totally agree. Without including it in the scipion's protocols.conf, the section is append at the end and in a different way (notice the bold font and the no 'C' in green). It's just a minor esthetic thing but I propose to include it. Also to give the hint as you mention. Without this PR: |
|
Theoretically there shoudn't be a difference. umm |
pconesa
approved these changes
Apr 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xmipp (localSharpening) and LocScale already have this section and it make sense to be in the tree after refine instead of at the end if not defined here.
Also I propose to include RelionPostProcess protocol in scipion-em/scipion-em-relion#52 PR.
It will looks like:
