[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn invalid NSP empty record #291

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Warn invalid NSP empty record #291

merged 3 commits into from
Dec 16, 2022

Conversation

quinnturner
Copy link
Member
@quinnturner quinnturner commented Dec 15, 2022 •
edited
Loading

Resolved the comment in #289

@quinnturner
Copy link
Member Author

@kyletsang thoughts?

@quinnturner quinnturner mentioned this pull request Dec 15, 2022
Merged
kyletsang
kyletsang approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor
@kyletsang kyletsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@quinnturner quinnturner merged commit 5b2cf71 into IBM:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyletsang kyletsang kyletsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quinnturner @kyletsang