[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added slugify migration file creater name and additional check to ensure migration files are not editied in PR #2039

Merged
merged 2 commits into from
Jul 2, 2024
Merged

feat: added slugify migration file creater name and additional check to ensure migration files are not editied in PR #2039

merged 2 commits into from
Jul 2, 2024

Conversation

akhilmhdh
Copy link
Member

Description 📣

  1. PR add a new check via Github Action to ensure in PRs migration files are not edited.
  2. Additionally added slugifying the input of migration file creator name so that it standardized

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@akhilmhdh
feat: added slugify migration file creater name and additional check …
506e86d 
…to ensure migration files are not editied in PR
@akhilmhdh akhilmhdh requested a review from maidul98 June 28, 2024 15:06
@akhilmhdh akhilmhdh self-assigned this Jun 28, 2024
maidul98
maidul98 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator
@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, lgtm

@maidul98 maidul98 merged commit 10601b5 into Infisical:main Jul 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maidul98 maidul98 maidul98 approved these changes

Assignees

@akhilmhdh akhilmhdh

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akhilmhdh @maidul98