[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix invalid isoformat string while comparing reports #690

Merged
merged 1 commit into from
May 15, 2023
Merged

[Bug] Fix invalid isoformat string while comparing reports #690

merged 1 commit into from
May 15, 2023

Conversation

wcchang1115
Copy link
Contributor

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
bug

What this PR does / why we need it:

  • make sure metrics query returns date format
  • bigquery's behavior is different from other data warehouses

Which issue(s) this PR fixes:
#676

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@wcchang1115
Make sure metrics query returns date format
ebbb387 
Signed-off-by: Wei-Chun, Chang <wcchang@infuseai.io>
@wcchang1115 wcchang1115 marked this pull request as ready for review May 12, 2023 10:38
@wcchang1115 wcchang1115 merged commit f2aa83e into main May 15, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popcornylu popcornylu popcornylu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wcchang1115 @popcornylu