New translate #179
New translate #179
Conversation
… for guide. Added onCursorActivity for update cursor position. Signed-off-by: Dmitry Mazurov <dimabzz@gmail.com>
Signed-off-by: Dmitry Mazurov <dimabzz@gmail.com>
Signed-off-by: Dmitry Mazurov <dimabzz@gmail.com>
|
@Ionaru What about my PR? |
|
Again, you cannot remove an option, because that is a breaking change. |
|
@Ionaru And what exactly will be the problem? I did autosave.text just recently. And this PR will quietly replace autosave.text with the default value. |
|
|
|
@Ionaru So it will work as before. I only changed the translation, which does not affect the work. |
| @@ -2025,7 +2042,7 @@ EasyMDE.prototype.autosave = function () { | |||
| if (el != null && el != undefined && el != '') { | |||
| var d = new Date(); | |||
| var dd = new Intl.DateTimeFormat([this.options.autosave.timeFormat.locale, 'en-US'], this.options.autosave.timeFormat.format).format(d); | |||
| var save = this.options.autosave.text == undefined ? 'Autosaved: ' : this.options.autosave.text; | |||
There was a problem hiding this comment.
But how does this affect work?
There was a problem hiding this comment.
If someone use this.options.autosave.text in this setting, this will not work anymore because you change to this.options.statusTexts.autosave. Old settings, should still work after your change.
There was a problem hiding this comment.
It will work, just reset to the default value.
var statusTexts = {
lines: 'lines: ',
words: 'words: ',
autosave: 'Autosaved: ',
};
There was a problem hiding this comment.
If the user adds translation of statuses, what prevents them from updating the AutoSave text? Despite the fact that it appeared recently.
There was a problem hiding this comment.
It will work, just reset to the default value.
var statusTexts = {
lines: 'lines: ',
words: 'words: ',
autosave: 'Autosaved: ',
};
But we should keep the user setting not the default setting, because this make a breakchange.
|
@Ionaru Hi. How exactly does the program break? |
|
I returned to the autosave. Are there any other problems that cause this PR to fail? |
|
The |
Added simple translate