[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose CodeMirror as static property #517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expose CodeMirror as static property #517

wants to merge 1 commit into from

Conversation

sn3p
Copy link
@sn3p sn3p commented Jan 11, 2023 •
edited
Loading

As requested in #495 (comment) :)

Unfortunately the CodeMirror object from EasyMDE is not available at that moment, although exposing it on the EasyMDE object should not be difficult (EasyMDE.CodeMirror = CodeMirror; in easymde.js, PR anyone? 😉).

@Ionaru
Copy link
Owner
Ionaru commented Jan 12, 2023

As discussed in #495, #514 and similar requests, I cannot guarantee a stable API when exposing CodeMirror or marked. Breaking changed to either package would mean a breaking change in this package. Tree-shaking might break anything from CodeMirror or marked that is used outside the editor.

I think a better option is to implement/expose specific configuration options that users of the editor need to achieve their goals.

@sn3p
Copy link
Author
sn3p commented Jan 13, 2023 •
edited
Loading

As discussed in #495 ...

You requested to expose it here 😆
But I do understand your concerns, feel free to close this PR.

It's just very frustrating you can't easily load CodeMirror modes before initializing eazyMDE.
Came up with a workaround in #495 (comment).

@sn3p sn3p mentioned this pull request Jan 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sn3p @Ionaru