Axes tip in AbstractArray interface
#47221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the `AbstractArray` interface to mention that the axes of an array should, in general, be their own axes. This is required for internal consistency, and if this is not enforced (e.g. by choosing `UnitRange`s as axes instead of `Base.IdentityUnitRange`s), one may come across unexpected bugs (see https://juliaarrays.github.io/OffsetArrays.jl/stable/internals/#Wrapping-other-offset-array-types for an example).
sostock
reviewed
Oct 21, 2022
|
Bump. Would be nice to get this merged. |
|
Is there anything that remains to be done in this? |
|
Gentle bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
AbstractArrayinterface to mention that the axes of an array should, in general, be their own axes. This is required for internal consistency, and if this is not enforced (e.g. by choosingUnitRanges as axes instead ofBase.IdentityUnitRanges), one may come across unexpected bugs (see https://juliaarrays.github.io/OffsetArrays.jl/stable/internals/#Wrapping-other-offset-array-types for an example).