UniformScaling: copyto!
banded matrices
#48445
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback method
fill!
s the array with zeros before copying to the diagonal. This seems redundant forDiagonal
and almost-diagonal banded matrices, as this involves two passes over the diagonal. This also resolves issues like JuliaArrays/FillArrays.jl#206, where the diagonal must necessarily be non-zero, and an attempt to set it to zero will lead to an error.Removing the redundancy cuts runtime by half, as expected:
On nightly
v"1.10.0-DEV.450"
This PR
I've added a simplified
FillArray
test-helper module, as I imagine this might be useful elsewhere as well.Something similar might also be necessary for
UnitLowerTriangular
andUnitUpperTriangular
, but that can be a separate PR