-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,13 +7,12 @@ parent: Code Howtos | |
|
||
Following is a list of common errors encountered by developers which lead to failing tests, with their common solutions: | ||
|
||
* `org.jabref.architecture.MainArchitectureTest` restrictStandardStreams <span style="color:red">FAILED</span> | ||
* <span style="color:green">Fix</span> : Check if you've used ```System.out.println(...)``` (the standard output stream) to log anything into the console. This is an architectural violation, as you should use the Logger instead for logging. More details on how to log can be found [here](https://devdocs.jabref.org/code-howtos/logging.html). | ||
* `org.jabref.architecture.MainArchitectureTest` `restrictStandardStreams` FAILED | ||
- Fix: Check if you've used ```System.out.println(...)``` (the standard output stream) to log anything into the console. This is an architectural violation, as you should use the Logger instead for logging. More details on how to log can be found [here](https://devdocs.jabref.org/code-howtos/logging.html). | ||
Check failure on line 11 in docs/code-howtos/faq.md
|
||
|
||
* `org.jabref.architecture.MainArchitectureTest` `doNotUseLogicInModel` FAILED | ||
- Fix: One common case when this test fails is when you put any class purely containing business logic at some level inside the ```model``` directory (```org/jabref/model/```). To fix this, shift the class to a subdirectory within the ```logic``` directory (```org/jabref/logic/```). | ||
Check failure on line 14 in docs/code-howtos/faq.md
|
||
|
||
* `org.jabref.architecture.MainArchitectureTest` doNotUseLogicInModel <span style="color:red">FAILED</span> | ||
* <span style="color:green">Fix</span> : One common case when this test fails is when you put any class purely containing business logic at some level inside the ```model``` directory (```org/jabref/model/```). To fix this, shift the class to a subdirectory within the ```logic``` directory (```org/jabref/logic/```). | ||
|
||
* `org.jabref.logic.l10n.LocalizationConsistencyTest` findMissingLocalizationKeys <span style="color:red">FAILED</span> | ||
* <span style="color:green">Fix</span> : You have probably used Strings that are visible on the UI (to the user) but not wrapped them using ```Localization.lang(...)``` and added them to the localization properties file (https://github.com/JabRef/jabref/blob/main/src/main/resources/l10n/JabRef_en.properties). | ||
* `org.jabref.logic.l10n.LocalizationConsistencyTest` `findMissingLocalizationKeys` FAILED | ||
- Fix: You have probably used Strings that are visible on the UI (to the user) but not wrapped them using ```Localization.lang(...)``` and added them to the [localization properties file](https://github.com/JabRef/jabref/blob/main/src/main/resources/l10n/JabRef_en.properties). | ||
Check failure on line 17 in docs/code-howtos/faq.md
|
||
Read more about the background and format of localization in JabRef [here](https://devdocs.jabref.org/code-howtos/localization.html). |