[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JabRef window expands to full screen on app start #4939

Closed
kbarros opened this issue May 2, 2019 · 21 comments · Fixed by #10128
Closed

JabRef window expands to full screen on app start #4939

kbarros opened this issue May 2, 2019 · 21 comments · Fixed by #10128
Labels
os: macOS preferences status: waiting-for-feedback The submitter or other users need to provide more information about the issue ui

Comments

@kbarros
Copy link
kbarros commented May 2, 2019

When starting the JabRef app, the JabRef window will expand to full screen. I would expect it to remember and reuse the window size from the last time JabRef was open. If such history is not available, I would expect JabRef to have a "reasonable" default (maybe 2/3 the screen size?)

JabRef 5.0-dev--snapshot--2019-05-01--master--f1b4b5be3
Mac OS X 10.14.4 x86_64
Java 1.8.0_212

@Siedlerchr Siedlerchr added this to ToDo in JavaFX UI Rework via automation May 3, 2019
@Siedlerchr
Copy link
Member

Hi,
this is odd. JabRef stores the main window size in the preferences and also if if the window is maximed or not. on Windows 10 this works fine. So it might be a mac thing.

@LinusDietz Can you confirm this?

@LinusDietz
Copy link
Member

Nope, when running JabRef with the current master it remembers the screen size as it should.

Mac OS X 10.14.4 x86_64
Java 1.8.0_202

@kbarros
Copy link
Author
kbarros commented May 11, 2019

That is strange, I tried again with today's snapshot and it still does not remember the window size.

JabRef 5.0-dev--snapshot--2019-05-11--master--3baa6bd22
Mac OS X 10.14.4 x86_64
Java 1.8.0_212

Where should it be storing the window size? I can check if this preferences file is being properly written on my machine.

@Siedlerchr
Copy link
Member

@kbarros JabRef uses the java-prefs feature to store the values.
Here are some hints where it is stored:
https://stackoverflow.com/a/675880

You could also check in Options -> Preferences -> Show all preferences
JabRef uses the following keys:

mainWindowSizeY
mainWindowSizeX
mainWindowPosY
mainWindowPosX

@Siedlerchr Siedlerchr added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label May 28, 2019
@stefan-kolb
Copy link
Member

Closing this issue due to inactivity 💤
Please reopen the issue with additional information if the problem persists.

JavaFX UI Rework automation moved this from ToDo to Completed Aug 24, 2019
github-actions bot pushed a commit that referenced this issue Jul 26, 2020
1f706cd Update health-services-research.csl (#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (#4932)
e79640e Create afro-asia.csl (#4934)
c601aa4 Update lancaster-university-harvard.csl (#4938)
184fd90 Update collection-du-centre-jean-berard.csl (#4936)
82f9aec fix et-al & add DOI thyroid.csl (#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (#4905)
3cab27d Update thieme-german.csl (#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (#4925)
4adb1ea Create karstenia.csl (#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 1f706cd
github-actions bot pushed a commit to calixtus/jabref that referenced this issue Jul 30, 2020
7cab2f7 Create depro-ufs.csl (JabRef#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949)
cd457d4 Update american-marketing-association.csl (JabRef#4945)
cacc4ee Create nejm-catalyst.csl (JabRef#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941)
1f706cd Update health-services-research.csl (JabRef#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932)
e79640e Create afro-asia.csl (JabRef#4934)
c601aa4 Update lancaster-university-harvard.csl (JabRef#4938)
184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936)
82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905)
3cab27d Update thieme-german.csl (JabRef#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925)
4adb1ea Create karstenia.csl (JabRef#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 7cab2f7
github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this issue Aug 1, 2020
827b986 add DOI preprint to american-society-for-microbiology.csl (JabRef#4946)
7cab2f7 Create depro-ufs.csl (JabRef#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949)
cd457d4 Update american-marketing-association.csl (JabRef#4945)
cacc4ee Create nejm-catalyst.csl (JabRef#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941)
1f706cd Update health-services-research.csl (JabRef#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932)
e79640e Create afro-asia.csl (JabRef#4934)
c601aa4 Update lancaster-university-harvard.csl (JabRef#4938)
184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936)
82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905)
3cab27d Update thieme-german.csl (JabRef#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925)
4adb1ea Create karstenia.csl (JabRef#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986
github-actions bot pushed a commit to RamonG92/jabref that referenced this issue Aug 1, 2020
827b986 add DOI preprint to american-society-for-microbiology.csl (JabRef#4946)
7cab2f7 Create depro-ufs.csl (JabRef#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949)
cd457d4 Update american-marketing-association.csl (JabRef#4945)
cacc4ee Create nejm-catalyst.csl (JabRef#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941)
1f706cd Update health-services-research.csl (JabRef#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932)
e79640e Create afro-asia.csl (JabRef#4934)
c601aa4 Update lancaster-university-harvard.csl (JabRef#4938)
184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936)
82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905)
3cab27d Update thieme-german.csl (JabRef#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925)
4adb1ea Create karstenia.csl (JabRef#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986
github-actions bot pushed a commit to Xuanxuan-Zou/jabref that referenced this issue Aug 1, 2020
827b986 add DOI preprint to american-society-for-microbiology.csl (JabRef#4946)
7cab2f7 Create depro-ufs.csl (JabRef#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949)
cd457d4 Update american-marketing-association.csl (JabRef#4945)
cacc4ee Create nejm-catalyst.csl (JabRef#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941)
1f706cd Update health-services-research.csl (JabRef#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932)
e79640e Create afro-asia.csl (JabRef#4934)
c601aa4 Update lancaster-university-harvard.csl (JabRef#4938)
184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936)
82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905)
3cab27d Update thieme-german.csl (JabRef#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925)
4adb1ea Create karstenia.csl (JabRef#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986
github-actions bot pushed a commit to dimitra-karadima/jabref that referenced this issue Aug 1, 2020
827b986 add DOI preprint to american-society-for-microbiology.csl (JabRef#4946)
7cab2f7 Create depro-ufs.csl (JabRef#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949)
cd457d4 Update american-marketing-association.csl (JabRef#4945)
cacc4ee Create nejm-catalyst.csl (JabRef#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941)
1f706cd Update health-services-research.csl (JabRef#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932)
e79640e Create afro-asia.csl (JabRef#4934)
c601aa4 Update lancaster-university-harvard.csl (JabRef#4938)
184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936)
82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905)
3cab27d Update thieme-german.csl (JabRef#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925)
4adb1ea Create karstenia.csl (JabRef#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986
github-actions bot pushed a commit to DominikVoigt/jabref that referenced this issue Aug 1, 2020
827b986 add DOI preprint to american-society-for-microbiology.csl (JabRef#4946)
7cab2f7 Create depro-ufs.csl (JabRef#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949)
cd457d4 Update american-marketing-association.csl (JabRef#4945)
cacc4ee Create nejm-catalyst.csl (JabRef#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941)
1f706cd Update health-services-research.csl (JabRef#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932)
e79640e Create afro-asia.csl (JabRef#4934)
c601aa4 Update lancaster-university-harvard.csl (JabRef#4938)
184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936)
82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905)
3cab27d Update thieme-german.csl (JabRef#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925)
4adb1ea Create karstenia.csl (JabRef#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986
github-actions bot pushed a commit to ShikunXiong/jabref that referenced this issue Aug 1, 2020
827b986 add DOI preprint to american-society-for-microbiology.csl (JabRef#4946)
7cab2f7 Create depro-ufs.csl (JabRef#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949)
cd457d4 Update american-marketing-association.csl (JabRef#4945)
cacc4ee Create nejm-catalyst.csl (JabRef#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941)
1f706cd Update health-services-research.csl (JabRef#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932)
e79640e Create afro-asia.csl (JabRef#4934)
c601aa4 Update lancaster-university-harvard.csl (JabRef#4938)
184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936)
82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905)
3cab27d Update thieme-german.csl (JabRef#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925)
4adb1ea Create karstenia.csl (JabRef#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986
github-actions bot pushed a commit to felixbohnacker/jabref that referenced this issue Aug 1, 2020
827b986 add DOI preprint to american-society-for-microbiology.csl (JabRef#4946)
7cab2f7 Create depro-ufs.csl (JabRef#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949)
cd457d4 Update american-marketing-association.csl (JabRef#4945)
cacc4ee Create nejm-catalyst.csl (JabRef#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941)
1f706cd Update health-services-research.csl (JabRef#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932)
e79640e Create afro-asia.csl (JabRef#4934)
c601aa4 Update lancaster-university-harvard.csl (JabRef#4938)
184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936)
82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905)
3cab27d Update thieme-german.csl (JabRef#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925)
4adb1ea Create karstenia.csl (JabRef#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986
github-actions bot pushed a commit to eetian/jabref that referenced this issue Aug 1, 2020
827b986 add DOI preprint to american-society-for-microbiology.csl (JabRef#4946)
7cab2f7 Create depro-ufs.csl (JabRef#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949)
cd457d4 Update american-marketing-association.csl (JabRef#4945)
cacc4ee Create nejm-catalyst.csl (JabRef#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941)
1f706cd Update health-services-research.csl (JabRef#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932)
e79640e Create afro-asia.csl (JabRef#4934)
c601aa4 Update lancaster-university-harvard.csl (JabRef#4938)
184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936)
82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905)
3cab27d Update thieme-german.csl (JabRef#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925)
4adb1ea Create karstenia.csl (JabRef#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986
github-actions bot pushed a commit to systemoperator/jabref that referenced this issue Aug 1, 2020
827b986 add DOI preprint to american-society-for-microbiology.csl (JabRef#4946)
7cab2f7 Create depro-ufs.csl (JabRef#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949)
cd457d4 Update american-marketing-association.csl (JabRef#4945)
cacc4ee Create nejm-catalyst.csl (JabRef#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941)
1f706cd Update health-services-research.csl (JabRef#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932)
e79640e Create afro-asia.csl (JabRef#4934)
c601aa4 Update lancaster-university-harvard.csl (JabRef#4938)
184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936)
82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905)
3cab27d Update thieme-german.csl (JabRef#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925)
4adb1ea Create karstenia.csl (JabRef#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986
github-actions bot pushed a commit to leitianjian/jabref that referenced this issue Aug 1, 2020
827b986 add DOI preprint to american-society-for-microbiology.csl (JabRef#4946)
7cab2f7 Create depro-ufs.csl (JabRef#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949)
cd457d4 Update american-marketing-association.csl (JabRef#4945)
cacc4ee Create nejm-catalyst.csl (JabRef#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941)
1f706cd Update health-services-research.csl (JabRef#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932)
e79640e Create afro-asia.csl (JabRef#4934)
c601aa4 Update lancaster-university-harvard.csl (JabRef#4938)
184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936)
82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905)
3cab27d Update thieme-german.csl (JabRef#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925)
4adb1ea Create karstenia.csl (JabRef#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986
github-actions bot pushed a commit to graffaner/jabref that referenced this issue Aug 1, 2020
827b986 add DOI preprint to american-society-for-microbiology.csl (JabRef#4946)
7cab2f7 Create depro-ufs.csl (JabRef#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949)
cd457d4 Update american-marketing-association.csl (JabRef#4945)
cacc4ee Create nejm-catalyst.csl (JabRef#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941)
1f706cd Update health-services-research.csl (JabRef#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932)
e79640e Create afro-asia.csl (JabRef#4934)
c601aa4 Update lancaster-university-harvard.csl (JabRef#4938)
184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936)
82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905)
3cab27d Update thieme-german.csl (JabRef#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925)
4adb1ea Create karstenia.csl (JabRef#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this issue Aug 1, 2020
827b986 add DOI preprint to american-society-for-microbiology.csl (JabRef#4946)
7cab2f7 Create depro-ufs.csl (JabRef#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949)
cd457d4 Update american-marketing-association.csl (JabRef#4945)
cacc4ee Create nejm-catalyst.csl (JabRef#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941)
1f706cd Update health-services-research.csl (JabRef#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932)
e79640e Create afro-asia.csl (JabRef#4934)
c601aa4 Update lancaster-university-harvard.csl (JabRef#4938)
184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936)
82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905)
3cab27d Update thieme-german.csl (JabRef#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925)
4adb1ea Create karstenia.csl (JabRef#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986
github-actions bot pushed a commit to joe9111/jabref that referenced this issue Aug 1, 2020
827b986 add DOI preprint to american-society-for-microbiology.csl (JabRef#4946)
7cab2f7 Create depro-ufs.csl (JabRef#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949)
cd457d4 Update american-marketing-association.csl (JabRef#4945)
cacc4ee Create nejm-catalyst.csl (JabRef#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941)
1f706cd Update health-services-research.csl (JabRef#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932)
e79640e Create afro-asia.csl (JabRef#4934)
c601aa4 Update lancaster-university-harvard.csl (JabRef#4938)
184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936)
82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905)
3cab27d Update thieme-german.csl (JabRef#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925)
4adb1ea Create karstenia.csl (JabRef#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986
github-actions bot pushed a commit to dextep/jabref that referenced this issue Aug 1, 2020
827b986 add DOI preprint to american-society-for-microbiology.csl (JabRef#4946)
7cab2f7 Create depro-ufs.csl (JabRef#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (JabRef#4949)
cd457d4 Update american-marketing-association.csl (JabRef#4945)
cacc4ee Create nejm-catalyst.csl (JabRef#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (JabRef#4941)
1f706cd Update health-services-research.csl (JabRef#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (JabRef#4932)
e79640e Create afro-asia.csl (JabRef#4934)
c601aa4 Update lancaster-university-harvard.csl (JabRef#4938)
184fd90 Update collection-du-centre-jean-berard.csl (JabRef#4936)
82f9aec fix et-al & add DOI thyroid.csl (JabRef#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (JabRef#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (JabRef#4905)
3cab27d Update thieme-german.csl (JabRef#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (JabRef#4925)
4adb1ea Create karstenia.csl (JabRef#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986
Siedlerchr pushed a commit that referenced this issue Aug 22, 2020
* Squashed 'src/main/resources/csl-styles/' changes from 586e0b8..c5f14e2

c5f14e2 Update journal-of-plant-ecology.csl (#4837)
b5d00ab Hotfix: pravnik.csl & iso690-full-note-cs.csl (#4833)
fb8d48a add PMID and DOI (#4832)
7ebdfff Update lancaster-university-harvard.csl (#4836)
8771e21 Create journal-of-clinical-neurology.csl (#4835)
70beb7b Harvard Lancaster: Fix in-text locator
0709b73 Update informal-logic.csl (#4831)
d18d133 Update gost-r-7-0-5-2008.csl (#4829)
cfb5389 Update gost-r-7-0-5-2008-numeric.csl (#4828)
0fc46ea Update gost-r-7-0-5-2008-numeric-alphabetical.csl (#4827)
fac26cb Create feminist-theory.csl (#4830)
a2721e6 Update pravnik.csl, masarykova-univerzita-pravnicka-fakulta.csl, and iso690-full-note-cs.csl (#4826)
2f0d735 Improve localization of DGfP
683d7d1 Create zeitschrift-fur-theologie-und-philosophie.csl (#4813)
7c82406 always show DOI in aps.csl (#4820)
1eb531d Update journal-of-international-business-studies.csl (#4819)
9caf926 Create interdisziplinare-anthropologie.csl (#4818)
00210e1 UKSW2 (#4807)
015db6e UKSW1 (#4800)
f706ef5 Update masarykova-univerzita-pravnicka-fakulta.csl (#4822)
096108d Update epilepsia.csl (#4823)
07ebdc3 Update eksploatacja-i-niezawodnosc.csl (#4824)
3d50f3c Create ABNT-Universidade-Federal-de-Pernambuco-CFCH.csl (#4798)
df94fa1 Update eksploatacja-i-niezawodnosc.csl (#4808)
4089be5 Update bulletin-de-la-societe-prehistorique-francaise.csl (#4810)
f130aa7 Update molecular-biology-and-evolution.csl (#4814)
86f452f Create heiliger-dienst.csl (#4815)
5ccd3e9 Update revista-brasileira-de-ciencia-do-solo.csl (#4817)
0eea734 Fix a delimiter in journal-of-the-royal-society-of-western-australia.csl (#4811)
1cbe790 Delete heiliger-dienst.csl
19fa29f Create heiliger-dienst.csl (#4787)
888bad1 Update RMIT Harvard to match Easy Cite (#4788)
46011dd Create universite-nangui-abrogoua-ufr-sn (#4676)
174adab Create apa-6th-edition-no-ampersand.csl (#4767)
03cf65f Create journal-of-plant-protection-research.csl (#4797)
c749084 Update eksploatacja-i-niezawodnosc.csl (#4782)
17e1501  Update masarykova-univerzita-pravnicka-fakulta.csl (#4783)
5596d18 Update revista-brasileira-de-ciencia-do-solo.csl (#4790)
9c1a381 create csl for the journal Textual Cultures (#4785)
8345762 Update taylor-and-francis-national-library-of-medicine.csl (#4786)
5ec1acf Create british-journal-of-criminology.csl (#4789)
68550ac Update angewandte-chemie.csl (#4791)
09e2755 Create shock.csl (#4792)
d46e49e Update antioxidants-and-redox-signaling.csl (#4793)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: c5f14e2

* Squashed 'src/main/resources/csl-styles/' changes from c5f14e2..716f635

716f635 Update changes in Harvard-Stellenbosch (#4862)
a6a9a1a Create alkoholizmus-a-drogove-zavislosti.csl (#4859)
0560ca0 Update journal-of-the-american-college-of-surgeons.csl (#4858)
9e16631 create independent style for cellular-and-molecular-gastroenterology-and-hepatology.csl (#4852)
87b0853 Update antiquity.csl (#4841)
cb4e7f7 Update heart-rhythm.csl (#4850)
b3b55ee Create iisue-moderno (#4846)
63973a7 Create etasr.csl (#4848)
9942138 Create style for Journal of Vertebrate Biology (#4849)
7c7f3d3 Add Future Medicine dependents (#4838)
abe2066 Update methods-of-information-in-medicine.csl (#4847)
c64d98b create independent style for new-zealand-journal-of-forestry-science (#4844)
28265f9 Create continuity-and-change.csl (#4839)
d065fdd Create journal-of-clinical-ethics.csl (#4842)
b9fbfa3 Update future-medicine.csl (#4843)
ceb56fa Create future-medicine.csl (#4834)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 716f635

* Squashed 'src/main/resources/csl-styles/' changes from 716f635..a995c63

a995c63 Create errata.csl (#4894)
883b9cd Update archeologie-medievale.csl (#4892)
a942b5c Update rmit-university-harvard.csl (#4890)
5d535fc Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (#4891)
f2a8fe3 Fix AVMA style
c5a2d7e Create universidade-do-porto-faculdade-de-engenharia-chicago.csl (#4872)
9f106eb Update rmit-university-harvard.csl (#4884)
5213c2f Update universitetet-i-oslo-rettsvitenskap.csl (#4886)
7e0828d Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (#4871)
ae5eba3 Create revue-archeologique-de-lest.csl (#4881)
58a1672 Create pacific-conservation-biology.csl (#4880)
381106e Update national-institute-of-organisation-dynamics-australia-harvard.csl (#4879)
c66a5c0 Create society-of-biblical-literature-author-date.csl (#4812)
008073c Create ruhr-universitat-bochum-medizinische-fakultat-variante-a.csl (#4874)
193385a Update manchester (#4878)
fa9ef11 Create Faculty of Psychology and Education Sciences, Porto (#4856)
2f70b14 Add "personal communication" to remaining APA locales (#4866)
2b4f831 Fixed page-range-format (#4863)
d5661ba universitat-bern-institut-fur-musikwissenschaft add missing cs:sort to cs:bibliography (#4860)
e433c99 fix delimiter issue for bioscience.csl (#4876)
4d97aab update et-al settings for stroke.csl (#4875)
342b9e3 Update masarykova-univerzita-pravnicka-fakulta.csl (#4868)
91fe25e Add article number to IEEE (#4867)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: a995c63

* Squashed 'src/main/resources/csl-styles/' changes from a995c63..bf698ac

bf698ac Create common-market-law-review.csl (#4910)
c962eca Create harvard-prifysgol-caerdydd.csl (#4922)
0c24e7f Update gewerblicher-rechtsschutz-und-urheberrecht.csl (#4923)
d2ec1a7 Create Tijdschrift-voor-Geneeskunde.csl (#4907)
5df7250 Update harvard-institut-fur-praxisforschung-de.csl (#4918)
093fd91 Update universite-de-montreal-apa.csl (#4916)
a3e41d4 Update thieme-german.csl (#4919)
648765a add DOI to aerosol-science-and-technology.csl (#4909)
bc1ebee Reindent/reorder
a8dc18a Fix documentation link for epidemiology & infection
aab403a Fix AGLC Newspaper date
4c018d5 Add period between editor and translator (SBL styles) (#4906)
42f7491 Create geographische-zeitschrift.csl (#4898)
a4002a6 Create german-kunstwissenschaft.csl (#4896)
b01910b Disambiguation of names (#4895)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: bf698ac

* Squashed 'src/main/resources/csl-styles/' changes from bf698ac..7cab2f7

7cab2f7 Create depro-ufs.csl (#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (#4949)
cd457d4 Update american-marketing-association.csl (#4945)
cacc4ee Create nejm-catalyst.csl (#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (#4941)
1f706cd Update health-services-research.csl (#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (#4932)
e79640e Create afro-asia.csl (#4934)
c601aa4 Update lancaster-university-harvard.csl (#4938)
184fd90 Update collection-du-centre-jean-berard.csl (#4936)
82f9aec fix et-al & add DOI thyroid.csl (#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (#4905)
3cab27d Update thieme-german.csl (#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (#4925)
4adb1ea Create karstenia.csl (#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 7cab2f7

* Squashed 'src/main/resources/csl-styles/' changes from 7cab2f7..827b986

827b986 add DOI preprint to american-society-for-microbiology.csl (#4946)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986

* Squashed 'src/main/resources/csl-styles/' changes from 827b986..eb0d37e

eb0d37e Create natbib-plainnat-author-dat.csl (#4967)
fb1592a Update journal-of-fish-biology.csl (#4969)
f6876cb Update .travis.yml (#4970)
d6d400b Create london-review-of-international-law.csl (#4966)
d2a5ae1 Update harvard-stellenbosch-university.csl (#4965)
9c62141 Create phytopathologia-mediterranea.csl (#4964)
8ca2ea1 Update historical-materialism.csl (#4960)
80456dc Update historical-materialism.csl
be2d910 Update historical-materialism.csl
1d1cf09 Create atlande.csl (#4930)
89f41d4 Create juristische-zitierweise-oeffentliches-recht.csl (#4944)
8c677a0 Create korean-journal-of-gastroenterology.csl (#4954)
eadb950 Create historical-materialism.csl (#4955)
5553dcd Create revista-materia.csl (#4957)
d23a3ab Bug fix in APA 6 original publication macro (#4959)
66f9974 Always print publisher in APA 6th edition (#4899)
868809c Create agora.csl (#4940)
99c19c3 Update anthropologie-et-societes.csl (#4952)
ee17423 Create critical-reviews-in-solid-state-and-materials-science.csl (#4951)
7a13a7d Create korean-journal-of-internal-medicine.csl (#4953)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: eb0d37e

* Merged new library actions

* l10n

* Removed unused constructor

* Fixed checkstyle failed check

* Fixed one more checkstyle issue

Co-authored-by: github actions <jabrefmail+webfeedback@gmail.com>
Siedlerchr pushed a commit that referenced this issue Oct 4, 2020
* Squashed 'src/main/resources/csl-styles/' changes from bf698ac..827b986

827b986 add DOI preprint to american-society-for-microbiology.csl (#4946)
7cab2f7 Create depro-ufs.csl (#4947)
2fcda1f Create journal-of-sport-science-and-medicine.csl (#4949)
cd457d4 Update american-marketing-association.csl (#4945)
cacc4ee Create nejm-catalyst.csl (#4943)
bd769b9 Update and rename dependent/chinese-medical-journal.csl to chinese-me… (#4941)
1f706cd Update health-services-research.csl (#4939)
76bcd1d Update journal-of-the-royal-society-of-western-australia.csl (#4932)
e79640e Create afro-asia.csl (#4934)
c601aa4 Update lancaster-university-harvard.csl (#4938)
184fd90 Update collection-du-centre-jean-berard.csl (#4936)
82f9aec fix et-al & add DOI thyroid.csl (#4937)
4af169f Create universidade-estadual-de-alagoas-uneal-abnt (#4885)
47165b3 Update and rename medical-physics.csl to dependent/medical-physics.csl (AMA) (#4905)
3cab27d Update thieme-german.csl (#4931)
eb2c977 Create zeitschrift-fur-zahnarztliche-implantologie.csl (#4925)
4adb1ea Create karstenia.csl (#4929)
530a136 Fix author substitute in Universita Cattolica

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 827b986

* Squashed 'src/main/resources/csl-styles/' changes from 827b986..eb0d37e

eb0d37e Create natbib-plainnat-author-dat.csl (#4967)
fb1592a Update journal-of-fish-biology.csl (#4969)
f6876cb Update .travis.yml (#4970)
d6d400b Create london-review-of-international-law.csl (#4966)
d2a5ae1 Update harvard-stellenbosch-university.csl (#4965)
9c62141 Create phytopathologia-mediterranea.csl (#4964)
8ca2ea1 Update historical-materialism.csl (#4960)
80456dc Update historical-materialism.csl
be2d910 Update historical-materialism.csl
1d1cf09 Create atlande.csl (#4930)
89f41d4 Create juristische-zitierweise-oeffentliches-recht.csl (#4944)
8c677a0 Create korean-journal-of-gastroenterology.csl (#4954)
eadb950 Create historical-materialism.csl (#4955)
5553dcd Create revista-materia.csl (#4957)
d23a3ab Bug fix in APA 6 original publication macro (#4959)
66f9974 Always print publisher in APA 6th edition (#4899)
868809c Create agora.csl (#4940)
99c19c3 Update anthropologie-et-societes.csl (#4952)
ee17423 Create critical-reviews-in-solid-state-and-materials-science.csl (#4951)
7a13a7d Create korean-journal-of-internal-medicine.csl (#4953)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: eb0d37e

* Adapt arxiv phrase test

Co-authored-by: github actions <jabrefmail+webfeedback@gmail.com>
@kschmid
Copy link
kschmid commented Jul 30, 2023

I am seeing this issue with Jabref 5.9 on MacBook running Ventura 13.5.
Checked advanced preferences: they show 0,0,768,1024 for the respective key values.
There is a preference in the personal library org.jabref.gui.plist (which I assumed would contain the relevant values), but last modification date is from early July. Other files under org.jabref. are even older (except for cli, which was modified only 2 days ago).
When opening preferences or advanced preferenced and hitting save, I get confirmation (library saved, resp. preferences saved), but these plists do not change. And next time I start again it is as large as the screen again (but not in full-screen mode).
Any idea, what could be the problem?

@Siedlerchr
Copy link
Member

Hi, I think I found the issue, apparently mac differs between maximized and full screen modus. I will create a PR to tix this

@kschmid
Copy link
kschmid commented Jul 31, 2023

thanks for taking this up again, only to clarify. The main problem is not the full screen. The main problem is:
I open it, it takes up the whole screen space (but not in full screen mode, which is fine). I resize it adequately.
The layout apparently does not get stored and next time it will open up with taking the whole screen again.

@Siedlerchr
Copy link
Member

Okay, this is weird. And not the behaviour I encounter. When I resize JabRef and quit with cmd + q on the next start, JabRef is in the same size. Do you have any external monitors connected?

@kschmid
Copy link
kschmid commented Jul 31, 2023

Ok, good to know, then it must a more local issue.
So far, I had done all this with (and on) local monitor. Prompted by your question. I closed, disconnected the external monitor. Reopened, Resized, quit and reopened. The same behavior: resizes to full laptop screen (macbook pro). If I than connect to the external monitor (primary), the window is moved to there and does keep roughly the laptop screen size.

I also checked whether there are issues with files and folders or full disk access, but Jabref has the rights for both. (I thought, might be an influence on the storing of preferences.)

@Siedlerchr
Copy link
Member

Can you test the latest development version if it makes a difference? https://builds.jabref.org/main/
You only need to execute xattr -d com.apple.quarantine /Applications/JabRef.app after extracting the dmg.

@kschmid
Copy link
kschmid commented Jul 31, 2023

Did it, no difference (neither the standalone from 1.7 nor the dmg from yesterday).
The dmg first asked for new access rights to files and folders, which I granted.

One thing I noticed (in general): when I double click the title bar, the window goes to a smaller size, but the size seems independent of prior scaling.

@Siedlerchr
Copy link
Member
Siedlerchr commented Jul 31, 2023

Ah now I can reproduce it as well and I found a solution

@Siedlerchr
Copy link
Member
Siedlerchr commented Jul 31, 2023

@kschmid Can you test this version? https://builds.jabref.org/pull/10128/merge
That should fix the issue

@kschmid
Copy link
kschmid commented Aug 3, 2023

Sorry for the delay, but traveling and there seems to be a bit more complex result, which I first had to test a bit more thoroughly.
a) It seems everything works now, if I close the application with the red x on the window.
b) if I close using cmd-q, it seems the window dimensions are not stored, the last layout that was initial while starting up is still used any resizing is forgotten.
In addition there is some behavior that I could not systematize (and never saw earlier). Sometimes on startup all columns are squished. see picture.
my-collection bib – JabRef 2023-08-03 09-42-58
In this case I did not find a way of realigning the columns to the way they should look (second picture)
my-collection bib – JabRef 2023-08-03 09-44-38
However, randomly after some restarts the layout looks again like it should. Here, I could not find a systematic dependency to the way I closed the app (appears to happen both ways).

@Siedlerchr Siedlerchr reopened this Aug 3, 2023
@Siedlerchr
Copy link
Member

Thanks for the feedback!
Yeah, I noticed that with CMD + Q as well. There maybe a solution using binding directly to the stage properties so that we don't rely on some close listener.

Regarding the column layout:
Do you have the option Fit table horizontically (or similar, don't have JabRef at hand right now) on screen enabled in the preferences? If yes try to disable this.

Do you see anything in the log?

@kschmid
Copy link
kschmid commented Aug 5, 2023

The culprit was indeed the Fit table. After deselecting it, the layout stays. (I never changed this. Apparently this is a default.) It implies that every once in a while the layout is fitted to a much smaller window size than the actual window size.
The log seems to conserve only current run? (Library/Logs/jabref/5.9.. (also menu entry).
Thus, I cannot see anything that may happen during close. In the available logs, I do not see anything that looks remotely strange.

@kschmid
Copy link
kschmid commented Aug 5, 2023

I am not familiar with FX and the details of the JabRef architecture. But after taking some time to poke around, I am wondering whether the close button vs. cmd-Q issue is related to the fact that:
JabRefGUI.java, line 158 calls saveWindowState
and then goes on to quit, while
JabRefFrame.java quit method (l. 456) does a lot of teardown work, but apparently does not save the window state.
(but perhaps this is completely off.. )

@Siedlerchr
Copy link
Member

Thanks for the hint, I will take a look, maybe this works!
PS: Getting started with coding in JabRef is not that hard https://devdocs.jabref.org/, and we are also part of some Software Engineering courses and, of course, open for collabs ;)

@Siedlerchr
Copy link
Member

@kschmid Your hint was correct, it works now for cmd + q as well. You can test the version here:
https://builds.jabref.org/pull/10143/merge

@kschmid
Copy link
kschmid commented Aug 7, 2023

Thanks, just tested it; works like a charm. Just looked at the commits. It was more difficult than expected. - Probably typical in an unknown code base.
Regarding collab. - Certainly interested. Seeing from code base and docu, it is much better than many other OS projects..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: macOS preferences status: waiting-for-feedback The submitter or other users need to provide more information about the issue ui
Projects
No open projects
JavaFX UI Rework
  
Completed
Development

Successfully merging a pull request may close this issue.

5 participants