[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lucene branch #11326

Draft
wants to merge 155 commits into
base: main
Choose a base branch
from
Draft

Update lucene branch #11326

wants to merge 155 commits into from

Conversation

LoayGhreeb
Copy link
Collaborator
@LoayGhreeb LoayGhreeb commented May 26, 2024 •
edited by koppor
Loading

This is a follow-up to #8963. We target main, because targetting luceneSearchBackend leads to much more "unrelated" commits.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

btut and others added 30 commits July 9, 2022 11:38
@btut
Cleanup index when opening a library
972bac7 
A user might have deleted a link to a fulltext-file in the source tex
file and we need to reflect that change in the index as well.
@btut
Changelog
dd81c9e
@btut
Remove debug output
f0c7039
@btut
Refractor to prepare for full lucene-search-backend
4e49146
@btut
Fix infinite recursion
4c40de6
@btut
Implement lucene search backend
59047f1
@btut
Consider fulltext-index-preference
be31a62
@btut
Better status-reporting for re-indexing on preference change
e88d5d0
@btut
Fix tests
ccad245
@btut
Prioritize BibEntry field changes
6ad3c2a
@koppor
Prepare CHANGELOG.md
21927c1
@btut
Trigger lucene-search in gui and display scoring
b78d3fe
@btut
Merge branch 'version6' into luceneSearchBackend
780f1a4
@btut
Don't prefix fields that users should be able to search in
d59d528
@btut
Matches in bib-fields should score higher than fulltext-matches
006b828
@btut
Refactoring
b19be22
@btut
Change file-icon if search yielded a fulltext-result
b89714a
@btut
Merge branch 'main' into version6
3cf15d1
@btut
Merge branch 'version6' into luceneSearchBackend
6711b40
@btut
Update index even if fulltext-index is disabled
a9f0e75
@btut
Adapt global search
750346f
@btut
Improved keyword indexing
00a7110
@btut
Remove debug output
60c9ed3
@btut
Improve global search
c71b749 
Make the results-counter react on the correct observables and actually
filter out results with score == 0
@btut
Checkstyle
9e7a41b
@btut
Don't listen for query-update for group-filtering
6ead73b
@btut
Switch SearchGroups to Lucene
5e4a780
@btut
Implement regex-string-wrapper
1c69125
@btut
Remove case-sensitive search preference
fe26dd1 
Lucene cannot do case-sensitive search
@btut
Remove case-sensitive button from group dialog
d759c24
LoayGhreeb and others added 3 commits June 25, 2024 14:48
@LoayGhreeb
Change SearchFieldConstants to enum
ab5388f
@LoayGhreeb
More performance improvements for searching
9242516 
- Read document only one time
- getHighlighterFragments only when the search results tab is opened
@LoayGhreeb
Merge branch 'main' into update-lucene-branch
2cc4f39
@koppor
Copy link
Member
koppor commented Jun 26, 2024

@LoayGhreeb Can you explain following issue?

/home/runner/work/jabref/jabref/src/test/java/org/jabref/logic/search/DatabaseSearcherWithBibFilesTest.java:14: error: package org.jabref.logic.pdf.search does not exist
import org.jabref.logic.pdf.search.PdfIndexer;
                                  ^

@LoayGhreeb
Copy link
Collaborator Author
LoayGhreeb commented Jun 26, 2024 •
edited
Loading

Can you explain following issue?

I moved the search classes out of the PDF package and removed the PdfIndexer class. However, I have not yet adapted the test classes.

@koppor
Copy link
Member
koppor commented Jul 3, 2024

@koppor koppor changed the base branch from main to luceneSearchBackend July 3, 2024 07:01
@koppor koppor changed the base branch from luceneSearchBackend to main July 3, 2024 07:02
@koppor koppor changed the base branch from main to luceneSearchBackend July 3, 2024 08:33
@koppor koppor changed the base branch from luceneSearchBackend to main July 3, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
project: GSoC search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LoayGhreeb @koppor @calixtus @btut @Siedlerchr