[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only a single, static instance of System.Random to generate payloads #1

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Use only a single, static instance of System.Random to generate payloads #1

merged 1 commit into from
Apr 5, 2022

Conversation

davidkroell
Copy link
Contributor

Hi, I was able to spot something for improvement.

This is due too two reasons:

  • System.Random implementation in .NET Framework (see System.Random on MSDN) and the added Test-Case
  • Performance

I've done a quick performance comparison using BenchmarkDotNet. With this small change, I was able to lower the allocated memory by ~80% and the generation time by ~85% for every single KSUID generated. This is due to the costly allocation of a new Random instance. The full result is printed below.

// * Summary *

BenchmarkDotNet=v0.13.1, OS=Windows 10.0.19043.1586 (21H1/May2021Update)
Intel Core i7-7500U CPU 2.70GHz (Kaby Lake), 1 CPU, 4 logical and 2 physical cores
.NET SDK=5.0.101
  [Host]     : .NET 5.0.1 (5.0.120.57516), X64 RyuJIT
  DefaultJob : .NET 5.0.1 (5.0.120.57516), X64 RyuJIT


|               Method |   N |         Mean |       Error |       StdDev |   Gen 0 | Allocated |
|--------------------- |---- |-------------:|------------:|-------------:|--------:|----------:|
|          CreateKsuid |   1 |   2,455.5 ns |    77.61 ns |    228.83 ns |  0.1678 |     352 B |
| CreateKsuidOptimized |   1 |     319.6 ns |     9.55 ns |     28.02 ns |  0.0343 |      72 B |
|          CreateKsuid |  10 |  25,078.5 ns |   709.29 ns |  2,091.34 ns |  1.6785 |   3,520 B |
| CreateKsuidOptimized |  10 |   3,283.2 ns |   104.70 ns |    305.41 ns |  0.3433 |     720 B |
|          CreateKsuid | 100 | 250,311.3 ns | 6,117.99 ns | 17,942.99 ns | 16.6016 |  35,200 B |
| CreateKsuidOptimized | 100 |  31,483.5 ns |   810.98 ns |  2,326.84 ns |  3.4180 |   7,200 B |

// * Warnings *
MultimodalDistribution
  KsuidBenchmark.CreateKsuidOptimized: Default -> It seems that the distribution is bimodal (mValue = 3.29)

// * Hints *
Outliers
  KsuidBenchmark.CreateKsuidOptimized: Default -> 1 outlier  was  removed (429.49 ns)
  KsuidBenchmark.CreateKsuidOptimized: Default -> 2 outliers were removed (4.38 us, 4.97 us)
  KsuidBenchmark.CreateKsuid: Default          -> 1 outlier  was  removed (301.74 us)
  KsuidBenchmark.CreateKsuidOptimized: Default -> 5 outliers were removed (38.53 us..42.95 us)

// * Legends *
  N         : Value of the 'N' parameter
  Mean      : Arithmetic mean of all measurements
  Error     : Half of 99.9% confidence interval
  StdDev    : Standard deviation of all measurements
  Gen 0     : GC Generation 0 collects per 1000 operations
  Allocated : Allocated memory per single operation (managed only, inclusive, 1KB = 1024B)
  1 ns      : 1 Nanosecond (0.000000001 sec)

@davidkroell
Use only a single, static instance of System.Random to generate payloads
e5e0fe5 
This is due too two reasons:
* System.Random implementation in .NET Framework
* Performance
@kinosang
Copy link
Contributor
kinosang commented Apr 5, 2022

Thanks for your contribution. The package will be avaliable on NuGet asap.

@kinosang kinosang merged commit 7cf045a into JoyMoe:master Apr 5, 2022
@kinosang
Copy link
Contributor
kinosang commented Apr 7, 2022

The package is now published at https://www.nuget.org/packages/Ksuid/1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidkroell @kinosang