Update Html parser to accept line-height:normal #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For acept text in line-height how "line-height:normal", etc.
troosan
requested changes
Apr 13, 2021
src/PhpWord/Shared/Html.php
Outdated
| if (preg_match('/([0-9]+\.?[0-9]*[a-z]+)/', $cValue, $matches)) { | ||
| if (preg_match('/([a-z]+)/', $cValue, $matches)) { | ||
| //$cvalue text and not number | ||
| if($cValue == 'normal') { |
There was a problem hiding this comment.
what else than 'normal' can it be? And why 1.12 for one and 1.13 for the other?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For acept text in line-height how "line-height:normal", etc.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Checklist:
composer run-script check --timeout=0and no errors were reported