Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (4745460) to head (8cc0c75).

@@            Coverage Diff             @@
##           master    #1005      +/-   ##
==========================================
- Coverage   94.98%   94.97%   -0.01%     
==========================================
  Files          87       87              
  Lines       21743    21743              
==========================================
- Hits        20652    20651       -1     
- Misses       1091     1092       +1     

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

I think the following files also have to be updated to stay self-consistent with this change:

• input.HELIOTRON_desc_no_continuation
• input.HELIOTRON_desc_no_continuation_output.h5
• basic_equilibrium.ipynb
• advanced_equilibrium_continuation.ipynb

the files that need updating have ben updated. The no continuation input does not need updating as the resolution was not changed for that one.

Feels really weird that going from m=8 to m=9 makes such a big difference?

Feels really weird that going from m=8 to m=9 makes such a big difference?

@dpanici are you sure this PR is necessary? The notebooks on master look like they already have the correct Shafranov shift

Feels really weird that going from m=8 to m=9 makes such a big difference?

@dpanici are you sure this PR is necessary? The notebooks on master look like they already have the correct Shafranov shift

Yea I am sure. If you rerun the examples on master, you completely lose the shafranov shift. Try it for yourself and see

Feels really weird that going from m=8 to m=9 makes such a big difference?

I also agree but this is the result I see, if the point of the notebook is to just use the automatic contiunation that by default is used when running on a vmec input file, it currently results in an equilibrium with barely any shafranov shift on master after running python -m desc input.HELIOTRON

This is fixed if we up the resolution by 1. The current saved input.HELIOTRON_output.h5 on master has L=M=8 resolution, so possibly what happened is it is from before we made the change so that when we load a VMEC input file, we set MPOL to be one less than what VMEC's MPOL is

ok, im still a bit worried this is indicative of some larger issue. Can you check to see when it broke? Was it just because we changed the default m from vmec?

Note to self, must make a new environment locally to load in older DESC versions

make as an issue then merge this in @dpanici