[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcore mode #5160

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Hardcore mode #5160

wants to merge 9 commits into from

Conversation

CI09
Copy link
Contributor
@CI09 CI09 commented May 27, 2024

Brief Description of What This PR Does

This PR adds hardcore mode - removes standard saving from game together with quicksaves and in place of auto-saves a save is performed that writes into one save name selected upon save creation.

Related Issues

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@CI09 CI09 added the review label May 27, 2024
@CI09 CI09 added this to In progress in Thrive Planning via automation May 27, 2024
@CI09 CI09 requested review from a team May 27, 2024 14:52
@hhyyrylainen hhyyrylainen added this to the Release 0.6.7 milestone May 27, 2024
Copy link
Contributor
@HexapodPhilosopher HexapodPhilosopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No bugs found. It is lacking a save on returning to the main menu, though. I was able to revert a bit by using that.

@hhyyrylainen
Copy link
Member

I didn't check but this mode should also suppress the warning for exiting without saving as this should force the save when exiting so that warning is not incorrectly shown.

Copy link
Member
@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs more bulletproofing against players exploiting the fact that the game doesn't save when exiting in this mode before I think this is a polished enough feature to include in the game.

@HexapodPhilosopher
Copy link
Contributor

Also, wouldn't it make sense to include the checkbox for this in the Difficulty settings, rather than Misc? It's where most people would look for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Thrive Planning
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants