fix: prevent broadcasting of system messages when hide setting is enabled #32522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: ffc4b55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32522 +/- ##
===========================================
+ Coverage 55.70% 56.44% +0.73%
===========================================
Files 2416 2481 +65
Lines 53471 54617 +1146
Branches 11002 11283 +281
===========================================
+ Hits 29787 30826 +1039
- Misses 21058 21108 +50
- Partials 2626 2683 +57
Flags with carried forward coverage won't be shown. Click here to find out more. |
1301b0b
to
38800b1
Compare
KevLehman
requested changes
May 29, 2024
apps/meteor/tests/unit/server/modules/watchers/lib/messages.spec.ts
Outdated
Show resolved
Hide resolved
KevLehman
reviewed
May 29, 2024
KevLehman
reviewed
Jun 6, 2024
KevLehman
requested changes
Jun 7, 2024
apps/meteor/tests/unit/app/lib/server/lib/getHiddenSystemMessage.spec.ts
Show resolved
Hide resolved
10afc76
to
6d51400
Compare
6d51400
to
71061cd
Compare
KevLehman
requested changes
Jun 7, 2024
79c05e4
to
0402cab
Compare
KevLehman
requested changes
Jun 11, 2024
ca7a74f
to
a322e44
Compare
KevLehman
approved these changes
Jun 12, 2024
…n-hide-system-message-is-set
…n-hide-system-message-is-set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This change ensures that system messages are not broadcasted when the setting to hide system messages is enabled. By checking the Hide_System_Messages configuration, the system will prevent unnecessary message broadcasts, improving message handling efficiency. This fix guarantees adherence to user-defined visibility settings for system messages.
Issue(s)
SUP-559
Steps to test or reproduce
Further comments
This update will enhance the efficiency of message handling by preventing the broadcast of system messages when configured to do so. This helps in maintaining cleaner logs and better performance in scenarios where certain system messages are not needed.