This repository has been archived by the owner on Jan 4, 2024. It is now read-only.
Fix NaïveProxy plugin release build #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yewip
pushed a commit
to Yewip/SagerNet
that referenced
this pull request
Feb 21, 2023
* Remove space in 'NAIVE_VERSION_NAME' * Fix build: trim name and verison properties in metadata * Quote dirname option in workflows
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous build workflows like this one failed due to a trailing space in
sager.properties, as mentioned in #587.This PR fixes that trailling space, while also prevent such situations by:
1a58a86trim name and verison when getting properties from metadataf1e0d1ddouble quote option ofdirnamein all workflowsI'm not sure if it's good to apply these two extra commits. If it's not, these two commits can be reverted.