[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Global Instructions #89

Merged
merged 1 commit into from
May 18, 2023
Merged

Conversation

kulcsaradam
Copy link
Contributor

No description provided.

src/jit/Backend.cpp Outdated Show resolved Hide resolved
src/jit/Backend.cpp Outdated Show resolved Hide resolved
src/jit/Backend.cpp Show resolved Hide resolved
src/jit/IntMath32Inl.h Outdated Show resolved Hide resolved
src/jit/IntMath32Inl.h Outdated Show resolved Hide resolved
src/jit/IntMath64Inl.h Show resolved Hide resolved
src/jit/Backend.cpp Outdated Show resolved Hide resolved
@kulcsaradam
Copy link
Contributor Author

I have made all suggested changes.

@kulcsaradam kulcsaradam requested a review from zherczeg May 18, 2023 08:54
src/jit/Backend.cpp Show resolved Hide resolved
src/jit/Backend.cpp Outdated Show resolved Hide resolved
src/jit/Backend.cpp Outdated Show resolved Hide resolved
src/jit/ByteCodeParser.cpp Outdated Show resolved Hide resolved
@kulcsaradam
Copy link
Contributor Author

Thanks for the insight, the changes are done.

Copy link
Collaborator
@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice patch! Only one minor thing remained.

@@ -109,7 +114,6 @@ class Instance : public Object {

DataSegment& dataSegment(uint32_t index) { return m_dataSegments[index]; }
ElementSegment& elementSegment(uint32_t index) { return m_elementSegments[index]; }

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be readded now, sorry for that.

Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
Copy link
Collaborator
@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg zherczeg merged commit 38b6644 into Samsung:jit_next May 18, 2023
@kulcsaradam kulcsaradam deleted the globals branch May 18, 2023 09:28
zherczeg pushed a commit that referenced this pull request Jun 2, 2023
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
zherczeg pushed a commit that referenced this pull request Jun 15, 2023
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
zherczeg pushed a commit that referenced this pull request Jul 4, 2023
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
zherczeg pushed a commit that referenced this pull request Jul 12, 2023
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
zherczeg pushed a commit that referenced this pull request Jul 20, 2023
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
zherczeg pushed a commit that referenced this pull request Jul 31, 2023
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
zherczeg pushed a commit that referenced this pull request Aug 10, 2023
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
zherczeg pushed a commit that referenced this pull request Aug 21, 2023
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
zherczeg pushed a commit that referenced this pull request Aug 28, 2023
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
zherczeg pushed a commit that referenced this pull request Sep 8, 2023
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
zherczeg pushed a commit that referenced this pull request Oct 2, 2023
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
zherczeg pushed a commit that referenced this pull request Oct 6, 2023
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
zherczeg pushed a commit that referenced this pull request Oct 12, 2023
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
clover2123 pushed a commit that referenced this pull request Oct 31, 2023
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
taperropein pushed a commit to taperropein/walrus that referenced this pull request Nov 10, 2023
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants