-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Global Instructions #89
Conversation
I have made all suggested changes. |
Thanks for the insight, the changes are done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice patch! Only one minor thing remained.
src/runtime/Instance.h
Outdated
@@ -109,7 +114,6 @@ class Instance : public Object { | |||
|
|||
DataSegment& dataSegment(uint32_t index) { return m_dataSegments[index]; } | |||
ElementSegment& elementSegment(uint32_t index) { return m_elementSegments[index]; } | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be readded now, sorry for that.
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
Signed-off-by: Adam Laszlo Kulcsar <kuladam@inf.u-szeged.hu>
No description provided.