[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ! from _substitute_pixel + v0.4.0 #84

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Remove ! from _substitute_pixel + v0.4.0 #84

merged 1 commit into from
Aug 21, 2022

Conversation

Saransh-cpp
Copy link
Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • Package installs: julia> ]dev .
  • All tests pass: julia> ]test ChaoticEncryption
  • The documentation builds: $ cd docs and then $ julia make.jl

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Acknowledgements

This Pull Request template was taken from the excellent PyBaMM repository.

@Saransh-cpp Saransh-cpp added the bug Something isn't working label Aug 21, 2022
@codecov
Copy link
codecov bot commented Aug 21, 2022

Codecov Report

Merging #84 (9eb2051) into master (af69f25) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #84   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           51        61   +10     
=========================================
+ Hits            51        61   +10     
Impacted Files Coverage Δ
src/substitution.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Saransh-cpp Saransh-cpp merged commit e1edd15 into master Aug 21, 2022
@Saransh-cpp Saransh-cpp deleted the inplace branch August 21, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant