[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Update CSSStyleRule to inherit from CSSGroupingRule #22482

Closed
shannonbooth opened this issue Dec 29, 2023 · 3 comments
Closed

LibWeb: Update CSSStyleRule to inherit from CSSGroupingRule #22482

shannonbooth opened this issue Dec 29, 2023 · 3 comments

Comments

@shannonbooth
Copy link
Member
shannonbooth commented Dec 29, 2023

After: w3c/csswg-drafts@4810428

We should make CSSStyleRule inherit from CSSGroupingRule

@shannonbooth shannonbooth added bug Something isn't working web compatibility labels Dec 29, 2023
@shannonbooth shannonbooth changed the title LibWeb: Prototype chain wrong for CSSStyleRule LibWeb: Update CSSStyleRule to inherit from CSSGroupingRule Dec 29, 2023
@shannonbooth shannonbooth removed the bug Something isn't working label Dec 29, 2023
@shannonbooth
Copy link
Member Author

Just updated this issue to be webcompat to match spec, I got quite confused by the issue here, and didn't realise this is a normative change to the draft spec from: w3c/csswg-drafts#8940

@AtkinsSJ
Copy link
Member

I'm a bit conflicted here. We don't implement any of the CSS-Nesting spec, and it's still a working draft. I wouldn't have expected that us not implementing this CSSOM change would cause issues, is there a website this is causing problems with?

Also this shows up on the CSSWG draft but not the published W3C draft.

Then again Chrome and Firefox both seem to implement some version of CSS-Nesting already without requiring any config changes.

We could probably do with a policy of what stage specs we implement, we're very inconsistent. But then so are other browsers. 🙃

@shannonbooth
Copy link
Member Author

Happy to close this! I originalyl thought the issue was somethingn else entirely, this one definitely seems like a non-issue. Will close it :^)

Just happened to stumble across while making other changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants