[css-nesting] Why does CSSStyleRule not inherit from CSSGroupingRule? #8940

emilio · 2023-06-09T15:41:57Z

https://drafts.csswg.org/css-nesting/#cssom-style has:

partial interface CSSStyleRule {
  [SameObject] readonly attribute CSSRuleList cssRules;
  unsigned long insertRule(CSSOMString rule, optional unsigned long index = 0);
  undefined deleteRule(unsigned long index);
};

Why doing that rather than inheriting from CSSGroupingRule, which gives you that?

cc @tabatkins @sesse

The text was updated successfully, but these errors were encountered:

emilio · 2023-06-09T18:24:13Z

cc @mdubet

mdubet · 2023-06-12T13:57:30Z

I've asked the same question during a WG meeting : #8350 (comment)

tabatkins · 2023-06-21T17:05:56Z

I honestly just didn't think about changing the inheritance tree? It feels like doing that to such an old rule might have compat implications, but then again CSSMediaRule is just as old and we changed it. So yeah, probably we can just do it this way.

css-meeting-bot · 2023-07-12T16:13:26Z

The CSS Working Group just discussed [css-nesting] Why does CSSStyleRule not inherit from CSSGroupingRule?, and agreed to the following:

RESOLVED: Change CSSStyleRule to inherit from CSSGroupingRule, modulo any discovered compat impact

The full IRC log of that discussion

<TabAtkins> emilio: Nesting spec extends CSSSTyleRule by copypasting CSSGroupingRule API
<TabAtkins> emilio: Think there was a point in the past we discussed enhancing CSSSTyleRule but discarded that
<TabAtkins> emilio: So maybe instead we could have CSSStyleRule inherit from CSSGroupingRule? Then enhancements from either come to both.
<TabAtkins> emilio: Would make it more likely that changes (like using observablearray) would apply to both
<TabAtkins> emilio: This is all assuming there's no compat impact.
<TabAtkins> emilio: Assuming that, I think this is the right thing to do.
<TabAtkins> No objections from me, modulo possible compat impact we'll find.
<TabAtkins> (it would be *relatively* hard to have a compat impact here, I imagine)
<TabAtkins> astearns: Objections?
<TabAtkins> RESOLVED: Change CSSStyleRule to inherit from CSSGroupingRule, modulo any discovered compat impact
<TabAtkins> emilio: I'd also expect compat to be rare
<TabAtkins> emilio: Few people use instanceof, they use duck-typing
<TabAtkins> emilio: And we shipped .cssRules on CSSStyleRule without issue

…gRule, so remove the now extraneous definitions from Nesting.

As per w3c/csswg-drafts#8940. I didn't do this in bug 1837638 because that's what the spec said at the time, that's what other browsers did, and specially because if we did this we had no way of runtime-disable nesting during development or if things went south. This means that we can't keep the nesting pref in 118, but that seems fine (it's already enabled everywhere in 117). Differential Revision: https://phabricator.services.mozilla.com/D184930 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1846251 gecko-commit: 085c31f150d35371620bb3f884c9f20b396dbe08 gecko-reviewers: peterv, devtools-reviewers

…v,devtools-reviewers As per w3c/csswg-drafts#8940. I didn't do this in bug 1837638 because that's what the spec said at the time, that's what other browsers did, and specially because if we did this we had no way of runtime-disable nesting during development or if things went south. This means that we can't keep the nesting pref in 118, but that seems fine (it's already enabled everywhere in 117). Differential Revision: https://phabricator.services.mozilla.com/D184930

As per w3c/csswg-drafts#8940. I didn't do this in bug 1837638 because that's what the spec said at the time, that's what other browsers did, and specially because if we did this we had no way of runtime-disable nesting during development or if things went south. This means that we can't keep the nesting pref in 118, but that seems fine (it's already enabled everywhere in 117). Differential Revision: https://phabricator.services.mozilla.com/D184930 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1846251 gecko-commit: 62534bac923526d52c2d5f377d00bdf2d34b9a05 gecko-reviewers: peterv, devtools-reviewers

…v,devtools-reviewers As per w3c/csswg-drafts#8940. I didn't do this in bug 1837638 because that's what the spec said at the time, that's what other browsers did, and specially because if we did this we had no way of runtime-disable nesting during development or if things went south. This means that we can't keep the nesting pref in 118, but that seems fine (it's already enabled everywhere in 117). Differential Revision: https://phabricator.services.mozilla.com/D184930

emilio · 2023-10-04T17:34:28Z

This has tests now, and spec text, so closing.

FWIW Gecko shipped this without issues.

As per w3c/csswg-drafts#8940. I didn't do this in bug 1837638 because that's what the spec said at the time, that's what other browsers did, and specially because if we did this we had no way of runtime-disable nesting during development or if things went south. This means that we can't keep the nesting pref in 118, but that seems fine (it's already enabled everywhere in 117). Differential Revision: https://phabricator.services.mozilla.com/D184930 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1846251 gecko-commit: 62534bac923526d52c2d5f377d00bdf2d34b9a05 gecko-reviewers: peterv, devtools-reviewers

…v,devtools-reviewers As per w3c/csswg-drafts#8940. I didn't do this in bug 1837638 because that's what the spec said at the time, that's what other browsers did, and specially because if we did this we had no way of runtime-disable nesting during development or if things went south. This means that we can't keep the nesting pref in 118, but that seems fine (it's already enabled everywhere in 117). Differential Revision: https://phabricator.services.mozilla.com/D184930

emilio added cssom-1 Agenda+ css-nesting-1 Current Work labels Jun 9, 2023

css-meeting-bot removed the Agenda+ label Jul 12, 2023

chromium-helper mentioned this issue Jul 12, 2023

[css-nesting] Why does CSSStyleRule not inherit from CSSGroupingRule? chromium-helper/csswg-resolutions#149

Closed

mozilla-apprentice mentioned this issue Jul 12, 2023

[css-nesting] Why does CSSStyleRule not inherit from CSSGroupingRule? mozilla/wg-decisions#1155

Open

tabatkins added a commit that referenced this issue Jul 14, 2023

[cssom][css-nesting] Per #8940, CSSStyleRule inherits from CSSGroupin…

4810428

…gRule, so remove the now extraneous definitions from Nesting.

tabatkins added Closed Accepted by CSSWG Resolution Needs Testcase (WPT) labels Jul 14, 2023

moz-wptsync-bot mentioned this issue Jul 31, 2023

[Gecko Bug 1846251] Make CSSStyleRule inherit from CSSGroupingRule. web-platform-tests/wpt#41248

Merged

emilio closed this as completed Oct 4, 2023

shannonbooth mentioned this issue Dec 29, 2023

LibWeb: Update CSSStyleRule to inherit from CSSGroupingRule SerenityOS/serenity#22482

Closed

andruud mentioned this issue Apr 29, 2024

[css-syntax][css-nesting] Design of @nest rule #10234

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[css-nesting] Why does CSSStyleRule not inherit from CSSGroupingRule? #8940

[css-nesting] Why does CSSStyleRule not inherit from CSSGroupingRule? #8940

[css-nesting] Why does CSSStyleRule not inherit from CSSGroupingRule? #8940

[css-nesting] Why does CSSStyleRule not inherit from CSSGroupingRule? #8940

Comments