[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Cooling option #23

Open
mrillies opened this issue Jun 1, 2019 · 7 comments
Open

Suggestion: Cooling option #23

mrillies opened this issue Jun 1, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@mrillies
Copy link
mrillies commented Jun 1, 2019

Hi, This widget looks quite powerful and well built.

It would be nice to have a cool or dual output function, making it similar to software version of an STC-1000.

From what i can see would only require a second output (or an additional message so as not to break current compatibility) and a second set of hysterisis values.

Thoughts or best to fork this to a seperate project?

@SergiuToporjinschi
Copy link
Owner

Hi, sorry for the late response...
Let me see if I understood. You want, basically to set a temperature interval and keep the temp in that interval. Let's say you put an upper limit and a lower limit.
Low: 20 and High; 25
and if the current temperature is 18 then turn the heater on and the cooler off;
if the current temperature is above 25 like 28 then turn the cooler on and heater off;
if the current temperature is 23 then turn the heater and the cooler off;
I understood correctly?

@mrillies
Copy link
Author
mrillies commented Jun 4, 2019 via email

@SergiuToporjinschi
Copy link
Owner

I understood you want to have a single temperature and not an interval like I described.
and with hysteresis. I would go on intervals like I proposed first time but with hysteresis for not killing the cooler and the heater. And I would go like this because I see it more flexible and I think would work for you too if you are setting both low and high on the same value. I think;

The problem is that I do not have time know and I'm planning to refactor this project because I don't like my code that I wrote. In fact I never like my code after it passes some time :)...

So, if you fork it I cannot grantee that I will be able to merge it after. and to merge it before refactoring is possible to be hard to refactor...

But nevertheless is a great idea and I will implement it;
Meanwhile, maybe you can achieve what you need by using same not twice in a workflow one for lowering temperature and one for rising it... I think you would have some work to there and is not user friendly ....

@SergiuToporjinschi SergiuToporjinschi added the enhancement New feature or request label Jun 4, 2019
@mrillies
Copy link
Author
mrillies commented Jun 4, 2019 via email

@SergiuToporjinschi
Copy link
Owner

aa no problem, be my guest :) yah maybe I can merge it ...

@ahmaddxb
Copy link

What part of the code would need to be changed in order for this to work for cooling. I want it to turn on when the temperature is higher then the target value rather than lower as it work now.

@shortyishere
Copy link

Did we add this an option for it to switch heating or cooling or add it as one module? I would like the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants