[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for invalid characters #177

Merged
merged 4 commits into from
Feb 17, 2023
Merged

Check for invalid characters #177

merged 4 commits into from
Feb 17, 2023

Conversation

PhyxionNL
Copy link
Contributor
@PhyxionNL PhyxionNL commented Feb 10, 2023 •
edited
Loading
  • Add compression level to bundles.

@Shazwazza This fixes #171 #135

@PhyxionNL
Check for invalid characters
d0877da 
+ Add compression level to bundles.
@Shazwazza Shazwazza changed the base branch from master to release/4.0.0 February 10, 2023 17:01
@Shazwazza Shazwazza changed the base branch from release/4.0.0 to master February 10, 2023 17:01
@Shazwazza
Copy link
Owner

Which version/branch did you want to target for this PR? I'm just doing a review and there seems to be some changes that are already done which makes me think that you don't want to target the master branch?

@PhyxionNL
Copy link
Contributor Author

It's based on the latest commit in master branch.

@Shazwazza Shazwazza merged commit 9510e0f into Shazwazza:master Feb 17, 2023
@PhyxionNL PhyxionNL deleted the file branch February 17, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shazwazza Shazwazza Shazwazza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smidge should do some validation before processing/writing a file
2 participants
@PhyxionNL @Shazwazza