[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quickpick UI to display addons list #2205

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Use quickpick UI to display addons list #2205

merged 1 commit into from
Jun 18, 2024

Conversation

st0012
Copy link
Member
@st0012 st0012 commented Jun 18, 2024

Motivation

This allows the extension to display multiple addons with enough space to show more attributes (e.g. gem name, version, etc.) in the future

Screenshot 2024-06-18 at 18 10 23

Closes #2197

Implementation

  • A new DisplayAddons command is introduced to trigger the quickpick UI
  • Each entry displays the addon's name and an icon indicating its errored status
  • Selecting an entry currently doesn't do anything

Automated Tests

Manual Tests

@st0012 st0012 added enhancement New feature or request addons Tasks related to Ruby LSP addons vscode This pull request should be included in the VS Code extension's release notes labels Jun 18, 2024
@st0012 st0012 self-assigned this Jun 18, 2024
@st0012 st0012 requested a review from a team as a code owner June 18, 2024 17:10
@st0012 st0012 requested review from andyw8 and vinistock June 18, 2024 17:10
Copy link
Member
@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's ensure command names are standardized to start with lower case.

vscode/package.json Outdated Show resolved Hide resolved
vscode/package.json Outdated Show resolved Hide resolved
vscode/src/common.ts Outdated Show resolved Hide resolved
- This allows the extension to display multiple addons with enough space to show
  more attributes (e.g. gem name, version, etc.) in the future
- Each entry displays the addon's name and an icon indicating its errored status
- Selecting an entry currently doesn't do anything
@st0012 st0012 enabled auto-merge (squash) June 18, 2024 18:01
@st0012 st0012 disabled auto-merge June 18, 2024 19:14
@st0012 st0012 merged commit cb10eb9 into main Jun 18, 2024
32 checks passed
@st0012 st0012 deleted the implement-#2197 branch June 18, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Tasks related to Ruby LSP addons enhancement New feature or request vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display addon information with quickpick UI
2 participants