[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I am sorry art comment moove #105

Merged
merged 17 commits into from
Oct 25, 2021

Conversation

IAmSorryArt
Copy link
Contributor

Description

Moved the comments one line up.
https://sonarcloud.io/project/issues?id=Slimefun_SensibleToolbox&open=AXTBKd9eH1YBO7_MeYrM&resolved=false&rules=java%3AS139&types=CODE_SMELL

Changes

Related Issues

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values

@IAmSorryArt IAmSorryArt requested a review from a team as a code owner October 24, 2021 21:36
@svr333
Copy link
Member
svr333 commented Oct 24, 2021

:NotLikeThis:

Copy link
Member
@Sefiraat Sefiraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Sefiraat
Copy link
Member

While looks good, I’m tempted to leave of merging until a fix has been provided for the RC27 update as a build may trigger people into redownloading it, only to find out it doesn’t work still :)

@Sefiraat
Copy link
Member

Never mind, been reminded that [CI Skip] exists and that my brain may not :D

@Sefiraat Sefiraat merged commit 89497f6 into Slimefun:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants