Fixes AutoBuilder block placement #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBusyBiscuit
approved these changes
Jul 16, 2021
There was a problem hiding this comment.
You have no idea how long this took me to wrap my head around.
I had to draw a binary table for the values and compare it to the original implementation:
I drew this by hand on a piece of paper but here you go, suffer with me :P
C := getBuildMode() == AutoBuilderMode.CLEAR
I := initInventoryPointer()
| C | I | !C | !I | !C & !I | C v I |
|---|---|---|---|---|---|
| 0 | 1 | 1 | 0 | 0 | 1 |
| 1 | 0 | 0 | 1 | 0 | 1 |
| 1 | 1 | 0 | 0 | 0 | 1 |
| 0 | 0 | 1 | 1 | 1 | 0 |
This part of STB really needs more documentation ._.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the AutoBuilder not being able to... build. The AutoBuilder has not been able to build for some time and it is an advertised feature of the machine.
Changes
AutoBuilder#startup was checking the internal inventory but was handling the return boolean incorrectly. I inverted this and the result was the builder working correctly. After this I then reversed the whole if statement as it read much better with two positive questions as opposed to two not checks.
Related Issues
Resolves #61
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values