[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Angelic Block height limiter #86

Merged
merged 4 commits into from
Jul 6, 2021

Conversation

Sefiraat
Copy link
Member
@Sefiraat Sefiraat commented Jul 5, 2021

Description

Added height limits to the Angelic Block's placement. Previously blocks were 'placable' outside of world bounds. While the block wouldn't actually appear, the placement would be remembered and particles would continue to spawn without a way for server owners to remove without directly editing config.

Changes

Added a check for the world height before the block placement is attempted.

Related Issues

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values

@Sefiraat Sefiraat requested a review from a team as a code owner July 5, 2021 07:32
Sefiraat and others added 3 commits July 5, 2021 11:48
…AngelicBlock.java

Co-authored-by: TheBusyBiscuit <TheBusyBiscuit@users.noreply.github.com>
Copy link
Member
@TheBusyBiscuit TheBusyBiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheBusyBiscuit TheBusyBiscuit merged commit d121a2b into Slimefun:master Jul 6, 2021
@Sefiraat Sefiraat deleted the angel-block-height branch July 6, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants