[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed vanilla items smelting from STB recipes #88

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

Sefiraat
Copy link
Member
@Sefiraat Sefiraat commented Jul 5, 2021

Description

Gunpowder and Glowstone could be smelted into Iron and Gold using a regular furnace. I have fixed this.

Changes

I am checking the recipe key to see if it was added by STB and, if so, any vanilla input is then rejected. Tested smelting the STB dusts (ok), Smelting vanilla ores (ok) and then gunpowder and glowstone (cancelled as expected)

Related Issues

Resolves #73

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values

@Sefiraat Sefiraat requested a review from a team as a code owner July 5, 2021 10:52
@TheBusyBiscuit TheBusyBiscuit merged commit 92333f3 into Slimefun:master Jul 16, 2021
@Sefiraat Sefiraat deleted the furnace-fix branch July 17, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gun powder can be crafted into iron ingots
2 participants