[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Slimefun blocks unable to be replaced #93

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

Sefiraat
Copy link
Member
@Sefiraat Sefiraat commented Jul 18, 2021

Description

The Multibuilder, in SWAP mode, could swap the material of Slimefun blocks. This allows the duping of blocks on a 1 by 1 basis. In the example provided on the Slimefun Discord, the Powered Bedrock block from Infinity Expansion constantly set's it's material back which allowed for a very fast and powerful dupe.

Changes

Given the potential issues, and that all STB blocks are also exempt from swapping, I have added a Blockstorage check to the canReplace() method should Simefun be present.
Added a isSlimefunEnabled variable and a getter to SensibleToolboxPlugin.java

Related Issues

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values

@Sefiraat Sefiraat requested a review from a team as a code owner July 18, 2021 16:33
Copy link
Member
@TheBusyBiscuit TheBusyBiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheBusyBiscuit TheBusyBiscuit merged commit dbcee02 into Slimefun:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants