Add devcontainer support #2987
Merged
Add devcontainer support #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
very interesting, I did not know this existed. So from what I understand this is a setup once and forget thing because if I add new dependencies in package.json or requirements it will always automatically pull them trough the install process right ? Also just out of curiosity, is this working with GitHub Codespaces? If so we could add a small hint that this works too, what do you think? |
|
Yes mostly setup once and forget. The only time it requires touching is if
you change the Dockerfile in requiring os level packages. If you do that,
you need to do it in both the dev container Dockerfile and the main one.
But in theory if you're changing that today documentation should be updated
to let folks know there's a new os level dependency.
package.json and requirements.txt changes all get picked up via recreating
the dev container.
It should also work with codespaces. I haven't used that before, but just
tried spinning it up now and it looked like it worked just fine. I've used
it extensively in vscode. For example it is what Home Assistant uses for
its development environment.
…On Wed, Feb 28, 2024, 10:35 PM vabene1111 ***@***.***> wrote:
very interesting, I did not know this existed. So from what I understand
this is a setup once and forget thing because if I add new dependencies in
package.json or requirements it will always automatically pull them trough
the install process right ?
Also just out of curiosity, is this working with GitHub Codespaces? If so
we could add a small hint that this works too, what do you think?
—
Reply to this email directly, view it on GitHub
<#2987 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFPT7NYDNHRMOZ3HFGKY7YTYV3F2NAVCNFSM6AAAAABD7CSGNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZQGQ4TONRZHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
thanks for the feedback and information, going to merge this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I started down the path of wanting to write test for #2978, but didn't want to deal with venvs and messing around with installing random dependencies on my machine. I've used devcontainers in the past to simplify creation of a development environment, and figured this would be great to simplify the development environment for tandoor.