[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted docstring tweaks #1158

Merged
merged 10 commits into from
Nov 11, 2022
Merged

Conversation

davep
Copy link
Contributor
@davep davep commented Nov 10, 2022

Just some assorted docstring tweaks and changes made while wandering through the code.

The value is bool, but the default is None. This makes the default False.
Google style docstring guidelines say that __init__ args can go either in
the class docstring, or the __init__ docstring; so this class was correct.
But the guidelines also recommend that once one approach has been picked it
should be the same over the whole body of the code. Textual mostly seems to
do it in the __init__ so I'm moving things to here and also adding some
missing args.
@willmcgugan willmcgugan merged commit b5b705e into Textualize:main Nov 11, 2022
@davep davep deleted the docstring-tidying branch November 11, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants