-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(badge-patch): fix for badge text center #67
Conversation
- patch fix for badge text center.
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@vonage/vivid-react", | |||
"version": "2.10.92", | |||
"version": "2.10.93", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you generated this with the yarn command or manually pushed?
in this project usually version is updated with the yarn command which is also tagging the master branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
src/patches/vwcBadge.js
Outdated
@@ -0,0 +1,21 @@ | |||
/** | |||
* Patches provided VwcBadge instance to show text in the center |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specify that this is for V3 of badges to not confuse with v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done