feat(badge-patch): fix for badge text center #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
- patch fix for badge text center.
dvelluto
reviewed
Jun 20, 2024
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@vonage/vivid-react", | |||
| "version": "2.10.92", | |||
| "version": "2.10.93", | |||
There was a problem hiding this comment.
did you generated this with the yarn command or manually pushed?
in this project usually version is updated with the yarn command which is also tagging the master branch
dvelluto
reviewed
Jun 20, 2024
src/patches/vwcBadge.js
Outdated
| @@ -0,0 +1,21 @@ | |||
| /** | |||
| * Patches provided VwcBadge instance to show text in the center | |||
There was a problem hiding this comment.
specify that this is for V3 of badges to not confuse with v2
dvelluto
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.