vwc-expansion-panel / vwc-expansion-panel-list #740
Replies: 5 comments 5 replies
-
|
more issues noticed
Expansion panel list PR can be found here |
Beta Was this translation helpful? Give feedback.
-
|
addressed in commit 040a733 |
Beta Was this translation helpful? Give feedback.
-
|
I would suggest adding capability to lazily render panel content, when opened only. This will save us some performance & issues with other components rendered when panel is closed & need to update/realign/relayout the content when panel is opened. |
Beta Was this translation helpful? Give feedback.
-
|
sure, considering template and containment. any other suggestions alike? or other ideas? |
Beta Was this translation helpful? Give feedback.
-
|
added to ticket https://jira.vonage.com/browse/VIV-519 |
Beta Was this translation helpful? Give feedback.
-
|
suggesting spec for part 1 - alternatively it's possible to follow angular's practice with multiple prop but again, not sure why to wrap with accordion... |
Beta Was this translation helpful? Give feedback.
-
|
Removed Dev can use alternative suggestion of I think |
Beta Was this translation helpful? Give feedback.
-
|
part 2 suggestion - @JoelGraham93 |
Beta Was this translation helpful? Give feedback.
-
|
added suggestion to PR |
Beta Was this translation helpful? Give feedback.
-
|
I think it makes more sense to default to |
Beta Was this translation helpful? Give feedback.
-
Topic 1
There are scenarios where a page may require all expansion panels to be open on render.
Currently
vwc-expansion-panelsupports anopenattribute which can be placed on each item.Alternatively we could also expose an
openAllprop onvwc-expansion-panel-list, but this could be a conflict.Topic 2
By design our default toggle icons for expansion panel are +/-
We also have a requirement to support chevron toggles
currently
chevronToggleboolean is being used. we don't have designs of more toggle types but maybe a stringtoggleIconmight be useful.Please comment your thoughts on suitable prop names.
mwc-tabs have an
indicatorIconprop that takes an icon and layers over the tab icon when active, rather than placing a line below. Slightly different use case but dropping here too for ideas.indicatoricon="donut_large"Beta Was this translation helpful? Give feedback.
All reactions